support modern language features

[mixmix]

Trying to noderify secret-stack@7 we get errors from acorn trying to parse ??=, ??, cb?.(), opts?.timeout etc

I've looked through the stack for the best solution and tried:

• ❌ set ecmaVersion: 2023. supposedly supported by the version of acorn we're using, but nope
• ✔️ mutated the detect function to "tidy" the new features into version which don't break the parser

I also tidied logging to make it easier to see at a glance if things are passing

[staltz]

Hey @mixmix in spirit this is great, and I've tried to do this myself once, but got lost in the complexity that is substack's forest of modules that handle this on top of acorn. acorn itself supports modern JS but the browserify ecosystem on top of it doesn't, yet.

Your PR however is going to cause at least two different kinds of showstopper bugs.

I recommend one these three:

• Do this PR properly by updating acorn and detective and resolve etc
• Don't update secret-stack to 7 (it didn't receive that very important updates compared to 6)
• (My favorite) Use esbuild instead of noderify. I've used it for other projects and it's really really good. Not only is it flexible and does everything that noderify does, it's faster and well maintained.

[staltz]

This is a big problem. Whoever uses the actual real supports-color npm package will not be able to use noderify.

If this is only for tests then there should be tests-specific flag that activate this.

[staltz]

This is ~80% likely to cause breaking changes out there. ??= cannot be replaced by = without causing bugs that are hard to detect. Example:

BEFORE

function init(opts) {
  opts.timeout ??= 5*60*60;
}

AFTER

function init(opts) {
  opts.timeout = 5*60*60;
}

Now whoever calls init({timeout: 2}) will feel super confused that the timeout ends up being 5 hours instead of the expected 2 seconds.

[mixmix]

yeah this doesn't mutate the code that's exported. I confirmed that in the bundle.
This only mutates the code that detective is looking at for require commands