Include package name and version in cache folder name#181
Merged
Conversation
Closed
Let's not default to naming the linter 'standard', as this increases the likelihood that another standard-engine linter variant will end up using the same cache folder name as the real `standard` linter.
Most of the time the user will be setting the version so it's not worth requiring standard-engine's package.json every time when it's not used
saves one function call
So for standard, the cache location would be: .standard-v12-cache/
Flet
approved these changes
May 14, 2018
Member
|
Looks good! 👍 |
Member
Author
|
9.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opts.cmdandopts.versioninLinter()Other small changes:
newcallrequire()Release this as a major version bump.
Fixes: #172