Skip to content
This repository was archived by the owner on Jun 15, 2022. It is now read-only.

Comments

feat: codeview enhancements#43

Merged
johnny243 merged 3 commits intomainfrom
enhancements
Mar 10, 2021
Merged

feat: codeview enhancements#43
johnny243 merged 3 commits intomainfrom
enhancements

Conversation

@johnny243
Copy link
Contributor

No description provided.

@johnny243 johnny243 requested a review from moughxyz March 9, 2021 08:42
@johnny243 johnny243 merged commit e175852 into main Mar 10, 2021
@johnny243 johnny243 deleted the enhancements branch March 10, 2021 01:28
@jmason888
Copy link

This commit utterly breaks by use case for the Plus editor. I use my own stylesheets (and even a little js) in almost all the notes where I use Plus (if I didn't need that, I'd be using the Bold editor instead). I've been using Plus this way for years, as a full-featured HTML editor/viewer, for a good number of my notes...

Kinda like editing in vi/emacs/notepad and viewing in the browser, only done within SN for security/privacy. I compose the notes in the Plain editor, then import them into Plus with all the formatting I want, and use Plus to view them (and edit, if necessary).

What's worse, I'm glad I have backups, and that most of my notes, once written are Locked. Because dompurify is removing custom classes and attributes from some of my tags, where these contain meaningful metadata, and is therefore causing a loss of valuable data anytime I try to edit an existing Plus note.

@jmason888
Copy link

@mobitar Between this change, the changes, to permissions, and the loss of the ability to search Protected notes, I'm getting very nervous about what other "enhancements" coming down the pipeline that may break my most important use cases for SN. I can't possibly be the only one for whom these are breaking changes.

jmason888 added a commit to segv11/plus-editor that referenced this pull request Mar 11, 2021
This reverts commit e175852 because the dompurify stuff breaks my use of custom css.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants