Skip to content

fix: install bn.js to fix js test error#7

Merged
ilyalesokhin-starkware merged 1 commit intostarkware-libs:masterfrom
xJonathanLEI:fix/js_test
Aug 16, 2022
Merged

fix: install bn.js to fix js test error#7
ilyalesokhin-starkware merged 1 commit intostarkware-libs:masterfrom
xJonathanLEI:fix/js_test

Conversation

@xJonathanLEI
Copy link
Contributor

Resolves #6.

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @xJonathanLEI)

@ilyalesokhin-starkware ilyalesokhin-starkware merged commit f956496 into starkware-libs:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JavaScript FFI test fails with Error: Cannot find module 'bn.js'

2 participants

Comments