Handle IPFS top-level with IPFS image URL#7
Merged
johnmosesman merged 3 commits intomainfrom Feb 11, 2022
Merged
Conversation
ryanlabouve
reviewed
Feb 11, 2022
| export const handleIpfs = async (tokenUri: string): Promise<Reason[]> => { | ||
| let reasons: Reason[] = [Reasons.tokenUriIsIpfs]; | ||
|
|
||
| let res: Metadata = await axios.get(tokenUri); |
Member
There was a problem hiding this comment.
We should add an issue to test fail case here
ryanlabouve
reviewed
Feb 11, 2022
|
|
||
| let res: Metadata = await axios.get(tokenUri); | ||
|
|
||
| if (res.image && isTokenUriIpfs(res.image)) { |
Member
There was a problem hiding this comment.
What is there is no res.image? Is that an error or a /shrug?
This would be nice to have a non-counted issue or warning
ryanlabouve
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.