adds support to recognize request limit error to the error plugin #30
Merged
timkolm merged 2 commits intostarweb:feature/readonly-properties-supportfrom Sep 25, 2020
Conversation
… sleep in incremental steps until the limit is released again
timkolm
requested changes
Sep 25, 2020
Member
timkolm
left a comment
timkolm
left a comment
There was a problem hiding this comment.
Good change!
One small naming suggestion
| */ | ||
| final class ErrorPlugin implements Plugin | ||
| { | ||
| private const SECONDS_TO_SLEEP_ON_MAX_REQUEST_PER_LIMIT_ERROR = 5; |
Member
There was a problem hiding this comment.
maybe it should be SECONDS_TO_SLEEP_ON_MAX_REQUEST_PER_MINUTE_ERROR ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://favro.com/organization/d98323ed4cfac48a92f11bf7/ce2fdb286ec7331714f87def?card=Sta-11929
Adds support to recognize max request errors from the SWS Shop API which will be returned if we send more than 1000 request per minute. Solve this by sleeping in incremental steps of five seconds before resending the request