JSONAPI::ActiveModelErrorSerializer Enhancements#103
Closed
tatethurston wants to merge 1 commit intostas:masterfrom
Closed
JSONAPI::ActiveModelErrorSerializer Enhancements#103tatethurston wants to merge 1 commit intostas:masterfrom
tatethurston wants to merge 1 commit intostas:masterfrom
Conversation
- Accept a response status provided to the error render. - Fix the source pointer for errors on the model's base.
tatethurston
commented
Jun 14, 2024
| { pointer: '/data' } | ||
| else | ||
| { pointer: '' } | ||
| { pointer: nil } |
Author
There was a problem hiding this comment.
Previous discussion: #45 (comment)
pointer: '' references the document root, which strikes me as the wrong fallback behavior here?
Original commit: 43cbaee
Owner
There was a problem hiding this comment.
This should return an empty object, since there's no source to point to.
Owner
|
Closing this in favor of #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings #45 up to date, dropping the previous error handling changes now that this library has dropped support for Rails < 6.
What is the current behavior?
What is the new behavior?
Checklist
Please make sure the following requirements are complete:
features)