Use is_a?(Enumerable) instead of respond_to?(:size) to detect collections#76
Merged
stas merged 7 commits intostas:masterfrom Mar 21, 2022
dmolesUC:issue-75
Merged
Use is_a?(Enumerable) instead of respond_to?(:size) to detect collections#76stas merged 7 commits intostas:masterfrom dmolesUC:issue-75
stas merged 7 commits intostas:masterfrom
dmolesUC:issue-75
Conversation
Owner
|
@dmolesUC any reason we don't want to switch to directly call |
Owner
|
Ah, nvm, just saw you answered in the issue. I'll merge this and fix the CI. Sorry about that. |
Contributor
Author
|
@stas |
This was referenced Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Non-collection objects with
sizeattribute are mistakenly treated as collections, causing serialization to fail (see #75).What is the new behavior?
Only
Enumerablesare treated as collections, cf. the corresponding method in jsonapi-serializer.Fixes #75.
Checklist
Please make sure the following requirements are complete:
features)
Notes
It looks like the build may be currently failing for other reasons?