Issue 90 let code be in error response#95
Closed
curtis741 wants to merge 4 commits intostas:masterfrom
Closed
Conversation
Owner
Please take a look at this one: |
… instead of rendering a resource that had an error.
Author
|
@stas I saw that file, all of those tests were testing the rendering of a resource that had an error. But there were no tests when you call It's cool, I got a new test all setup so you've now got more test coverage. |
Author
|
@stas does this PR look good now? |
Author
|
@stas any feedback on this PR? |
Author
|
thanks @stas ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
code is not included when using the
jsonapi_errorsrendererWhat is the new behavior?
code is included when using
render jsonapi_errorsChecklist
I couldn't actually run the tests with a clean checkout from master on 2.0.1.
Also I don't see any tests for
render jsonapi_errors? maybe I'm missing it...Please make sure the following requirements are complete:
features)