Patch candidates fixes #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
waskyo
commented
Dec 2, 2024
waskyo
commented
- Allow targets to be unspecified in which case we collect information for all of them
- Make things work on MIPS. The original code was hardcoded for ARM.
- Add JSON output
in that case we will include all targets, instead of none
waskyo
force-pushed
the
patch_candidates_fixes
branch
from
a418ba7 to
cb6c1ed
Compare
Moved all the json functionality into the LibrarySideEffect class so that the json and txt output could share the same path.
… thing We were converting it to a string with becomes 'None' which then throws off the json parser
waskyo
force-pushed
the
patch_candidates_fixes
branch
from
cb6c1ed to
e46f7c0
Compare
…ck to the reportcmds And pass them in to the to_json_result method. Instead of passing in an AppAccess object. Per Henny's code review, doing all that work inside of the LibraryCallSideEffect class creates undesirable dependencies.
waskyo
force-pushed
the
patch_candidates_fixes
branch
from
869d5d2 to
ede8dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.