Misc fixes #194
Merged
Misc fixes #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
waskyo
commented
Feb 4, 2025
waskyo
commented
- Fix for infinite recursion when stack offset is not present in a stack variable introduction.
- Fix for possibly unbound variable in ARMStoreRegisterHalfword.py.
- Switch return value of ARMStoreRegisterHalfword:ast_prov to use variables that were being assigned to but not used. I'm not sure if this is correct though.
…duction this also fixes how we handle a stack variable introduction without an offset. Before we would issue a warning, then raise the non-positive error. This switches it to raising an error if the offset is not there, and also issue an error if the values is non-positive
- If hitting the right path, lhs was potentially unbound. This makes it None in that path and we check for it - The ll_assigns and hl_assigns variable were showing up as unused. I switched things over to use them as the return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.