Support Xcode-only build. #2
Conversation
samueljohn
commented
Jul 14, 2012
samueljohn
commented
- Patch included to respect CFLAGS/CXXFLAGS and CPPFLAGS in order to allow to build with Xcode only (no Command Line Tools needed)
- Remove -I entry from LDFLAGS because in deps/Makefile there is a find command that searches all -L pathes in LDFLAGS. The "-I" in LDFLAGS is not substituted.
- Patch included to respect CFLAGS/CXXFLAGS and CPPFLAGS in order to allow to build with Xcode only (no Command Line Tools needed) - Remove -I entry from LDFLAGS because in deps/Makefile there is a find command that searches all -L pathes in LDFLAGS. The "-I" in LDFLAGS is not substituted.
|
A little comment: I don't want you to pull this right away but to look at it and perhaps the necessary changes (respecting CFLAGS, CXXFLAGS and CPPFLAGS) can be fixed upstream in julia. I know you are a contributer there :-) A know very little of julias internal workings, so perhaps I did break some other things? At least I can build julia and get the test as far as the glpk tests failing with JuliaLang/julia#1047. One maybe-issue is that uv is reported to have no symbols. I don't know is that is ok. |
julia.rb
Outdated
There was a problem hiding this comment.
I had no issues with parallel builds. But actually this deletion slipped in. Sorry.
There was a problem hiding this comment.
At this point, we're getting errors commonly enough due to Julia's evolving build process that I have the build deparallelized to make debugging error logs easier. It's much simpler to see what's going on when you don't have 2-3 programs outputting simultaneously.
There was a problem hiding this comment.
You are right. It slipped in because you just recently added it and I forked before that point in time.
This should make it break less often, because the git patches apply only if both hashes are checked. Therefore, any small change in any of the patches files breaks the whole patch. With inreplace we search/replace only a certain line. Added doc about the LDFLAGS thing.
|
I think Xcode-only installs are really valuable, as it opens up the install process to even more of the population. Once we get a few of these things merged upstream, I'll gladly accept the stuff that makes sense to be in the formula. Thank you for all your hard work on getting Homebrew into shape for Xcode-only compiles, btw! |
|
And don't worry about libuv not having any symbols; as far as I know, libuv is only used on windows as a compatibility layer, so it not having any symbols is just fine. |
|
Alright, and in turn, thanks for making the julia formula :-) Would be good to have a build option or variable in julia where we can pass and overwrite the location of some of the includes. |
|
What kind of overrides are you thinking? Is messing around with |
|
Hmmm you are right, if the calls to Otherwise I thought setting |
|
Yeah, cpp should always take in |
|
We agree :-) |
|
No longer needed. There is a new pull request that works with latest homebrew (tested on 10.8) and works without inreplace stuff. |
2 participants
