Skip to content

import networkLite and define as.networkDynamic.networkLite#16

Merged
skyebend merged 10 commits intomasterfrom
networkLite
Feb 5, 2023
Merged

import networkLite and define as.networkDynamic.networkLite#16
skyebend merged 10 commits intomasterfrom
networkLite

Conversation

@chad-klumb
Copy link
Contributor

This PR imports the (new) networkLite package and defines as.networkDynamic.networkLite (which is needed to support tergm applications of networkLites). This will permit e.g. ergm to import networkLite without depending on networkDynamic. Version number and ChangeLog have been updated.

@skyebend
Copy link
Contributor

skyebend commented Sep 8, 2022

As Chad notes, networkLite needs to be on CRAN first, and probably remotes lite removed before merging to master

next CRAN push could be organized to first push networkLite, then push
statnet packages in the usual order, then push the EpiModel package
after tergm goes up.

chad-klumb added a commit to EpiModel/networkLite that referenced this pull request Sep 11, 2022
and update documentation, tests, etc.

references statnet/networkDynamic#16
set.nD.class does, but this does not modify the argument passed to the network method (or the generic)
but note that the `EpiModel/networkLite@networkLite` branch is the one to use (until it's merged into main, anyway)
@skyebend
Copy link
Contributor

sorry I haven't been following up on this. Looks like I need to do a release to CRAN this weekend to quiet some other issues. Are the reverse depends ready for this if we try to include it?

@skyebend
Copy link
Contributor

just noticed this in the CRAN docs, wondering if the correct relationship with networkLite is 'enhances'?

Finally, the ‘Enhances’ field lists packages “enhanced” by the package at hand, e.g., by providing methods for classes from these packages, or ways to handle objects from these packages (so several packages have ‘Enhances: chron’ because they can handle datetime objects from chron even though they prefer R’s native datetime functions). Version requirements can be specified, but are currently not used. Such packages cannot be required to check the package: any tests which use them must be conditional on the presence of the package. (If your tests use e.g. a dataset from another package it should be in ‘Suggests’ and not ‘Enhances’.)

@krivit
Copy link
Member

krivit commented Nov 20, 2022

Yes, I believe Enhances is the right relationship.

@chad-klumb
Copy link
Contributor Author

networkLite is not on CRAN so this will have to wait for a later release

some people dislike Enhances, e.g.

  • Enhances: packages listed here are “enhanced” by your package. Typically, this means you provide methods for classes defined in another package (a sort of reverse Suggests). But it’s hard to define what that means, so we don’t recommend using Enhances.

https://r-pkgs.org/dependencies.html

@smjenness
Copy link
Member

HI @skyebend!

networkLite is now on CRAN: https://cran.r-project.org/package=networkLite

Would you please merge this PR and push networkDynamic up to CRAN.

Once complete, we can continue updating EpiModel and related packages.

Thanks! Sam

@skyebend skyebend merged commit 7e382b3 into master Feb 5, 2023
@smjenness
Copy link
Member

Hi @skyebend : it looks like you merged this PR into master last week. Could you push this latest version up to CRAN? We are waiting on updating and publishing EpiModel for this newest version of networkDynamic to be on CRAN. Thanks!

@skyebend
Copy link
Contributor

@smjenness Yes, I merged, but was having trouble getting revdep tests to run locally (seemed more like a failure of revdep than statnet package problems) I'll try some more today, @chad-klumb were you able to run this previously, do we feel pretty confident that reverse-depending 3rd party packages will be ok?

@chad-klumb
Copy link
Contributor Author

revdepcheck did not indicate any issues

@skyebend
Copy link
Contributor

submitted (sorry for delay). leaving this open to remember to push branch if it is sucessful

@skyebend
Copy link
Contributor

'package networkDynamic_0.11.3.tar.gz is on its way to CRAN.'

@smjenness
Copy link
Member

Excellent, thanks @skyebend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants