ASIO backend#6
Open
AndySaul wants to merge 100 commits intostdcpp-audio:masterfrom
AndySaul:asio_backend
Open
Conversation
gsomberg314
reviewed
May 30, 2019
gsomberg314
reviewed
May 30, 2019
gsomberg314
reviewed
May 30, 2019
gsomberg314
reviewed
May 30, 2019
gsomberg314
reviewed
May 30, 2019
gsomberg314
reviewed
May 30, 2019
gsomberg314
reviewed
May 30, 2019
Contributor
gsomberg314
left a comment
gsomberg314
left a comment
There was a problem hiding this comment.
Thanks for implementing this! I've made a few comments, and then we can merge this in.
Author
|
Hi Guy, Thanks for the review :) I will make changes & comment as requested |
Author
|
I need to rebase on top of master so that this can be merged. I may take the opportunity to squash in some of the latest changes |
All samples now compile without error on Windows
This is a copy of __null_backend.h initially
ASIO drivers use different underlying sample types so that the driver can specify an efficient native format. P1386R1 has no mechanism to query native sample type.
This is to be expected on hosts without ASIO drivers. If the root ASIO key is not found, enumerating subkeys will fail, so ASIO devices will not be created
As per Specification Style Guidelines
|
How is this going to work with the ASIO SDK being proprietary? On GCC where GPL is used as license, the ASIO SDK is inherently incompatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Windows ASIO backend to the library.
Currently, the ASIO driver is the default option as there is no WASAPI implementation. The device selection API would need to be templatized as per 6.4 to allow this.