bench: refactor to use string interpolation in ndarray/base#11437
Conversation
… (batch 8/9)
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
@stdlib/ndarray/base (batch 8/9)ndarray/base (batch 8/9)
|
@kgryte Before I try to fix the lint error here, could I please confirm if the right way to do it is: For the non-blocked |
|
@anandkaranubc Yes, please! I have in my local notes the following todo items: |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Thanks! Should be done now. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
@anandkaranubc Would you mind resolving the merge conflicts? 😬 |
# Conflicts: # lib/node_modules/@stdlib/ndarray/base/to-reversed/benchmark/benchmark.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.10d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.10d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.2d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.2d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.2d_rowmajor_accessors.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.2d_rowmajor_accessors_complex.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.3d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.3d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.4d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.4d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.5d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.5d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.6d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.6d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.7d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.7d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.8d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.8d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.9d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary-by/benchmark/benchmark.9d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.10d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.10d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.2d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.2d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.2d_rowmajor_accessors.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.2d_rowmajor_accessors_complex.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.3d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.3d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.4d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.4d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.5d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.5d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.6d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.6d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.7d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.7d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.8d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.8d_rowmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.9d_columnmajor.js # lib/node_modules/@stdlib/ndarray/base/unary/benchmark/benchmark.9d_rowmajor.js
| }); | ||
|
|
||
| bench( pkg+'::2d,base', function benchmark( b ) { | ||
| bench( format( '%s::2d,base', pkg ), function benchmark( b ) { |
There was a problem hiding this comment.
Are we also updating patterns like these to
bench( format( '%s::base:ndims=2', pkg ), ... )?
There was a problem hiding this comment.
Yes, ideally. Some descriptions should use parameterization, rather than namespacing. This is an example of such a case.
This is where having plot support would be useful, as such patterns would be more evident based on visualization faceting. Sigh.
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Any further modifications can be addressed in follow-up PRs.
ndarray/base (batch 8/9)ndarray/base
Progresses #8647
Progresses stdlib-js/metr-issue-tracker#403
Description
This pull request:
@stdlib/ndarray/baseRelated Issues
This pull request has the following related issues:
@stdlib/ndarraymetr-issue-tracker#403Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used a Cursor driven Skill+Workflow to achieve this migration with manual and automated sanity checks.
@stdlib-js/reviewers