docs: update notes#12130
Merged
Merged
Conversation
…lumn` Replace `unable to find a search vector` with `unable to find a matching column` in the JSDoc and TypeScript declarations to match the README and the wording used by the analogous `dindex-of-column` package.
…lumn` Replace `unable to find a search vector` with `unable to find a matching column` in the JSDoc and TypeScript declarations to match the README and the wording used by the analogous `dindex-of-column` package.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
May 17, 2026
kgryte
reviewed
May 17, 2026
b4606f8 to
acae714
Compare
develop on 2026-05-13/14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-05-13 20:52 PDT (360877d) and 2026-05-14 02:11 PDT (80b1ef7).Description
Audit of the 15 first-parent commits merged to
developover the last 24 hours surfaced two high-signal items, grouped by package below. Each commit on this branch corresponds to a single package fix.blas/ext/base/cindex-of-column995d771—lib/cindex_of_column.js,lib/ndarray.js, anddocs/types/index.d.tsall said "unable to find a search vector" instead of "unable to find a matching column", contradicting both the README and the analogousdindex-of-columnpackage.blas/ext/base/zindex-of-column62dad13wherelib/zindex_of_column.js,lib/ndarray.js, anddocs/types/index.d.tsdescribed the no-match condition as "unable to find a search vector" rather than "matching column", replacing all 5 occurrences to match the README anddindex-of-columnreference implementation.Related Issues
None.
Questions
None.
Other
Validation
Audited the 15-commit window with two parallel style-compliance reviewers (compared each substantive new file against established reference packages —
dindex-of-column/sindex-of-columnfor the new column-search packages,transpose-operation-{str2enum,enum2str}for the kmeans enum utilities,ndarray/zeros/ndarray/onesforndarray/nans) and two parallel bug reviewers (one diff-only, one with full source-file context). Findings were de-duplicated and each surviving issue re-verified against the diff before applying.Items raised during the audit but deliberately excluded from this PR:
_ndarrayroutines incindex-of-column/zindex-of-columnuse signedstrideA1 <= strideA2for column-major detection while the JS path uses absolute-valueisColumnMajor. The same divergence exists in the pre-existingdindex-of-column/sindex-of-column/gindex-of-columnC sources, so addressing it would require a family-wide fix outside this window's scope.sindex-of-columnuses "stride length for",dindex-of-columnuses "stride of"); not a clear violation.numpy.nanskeyword tondarray/nans/package.json— its removal in65cbb12is the explicit purpose of that commit.extendedkeyword to the newcindex-of-column/zindex-of-columnpackage.jsonfiles — the analogousdindex-of-columndoes not carry it, so no divergence exists.dnrm2@returns L2-normtag inblas/base/ndarray/docs/types/index.d.ts— matches the wording already used by the standaloneblas/base/dnrm2andblas/base/ndarray/dnrm2declarations.Update
Originally this PR also proposed replacing the imported
isNumber/isStringguards inml/base/kmeans/algorithm-str2enumandalgorithm-enum2strwith inlinetypeofchecks to match the BLAS*2enumpackages. Per review by @kgryte, the kmeans packages are correct as-is — it is the BLAS packages that should adopt the imported utility. Both commits have been dropped.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated daily review pass over commits merged to
develop. Each finding was independently verified against the diff and the cited reference packages before applying. The PR is being opened as a draft for human audit; please do not promote to ready-for-review until the changes have been confirmed.