test: fix typo in test description#12176
Merged
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
blas/ext/base/gaxpb test description
kgryte
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-05-16 23:58:43 -0700 and 2026-05-17 01:31:08 -0700.That window contained 11 first-parent commits: two new BLAS packages (
blas/ext/base/gaxpb,blas/base/ndarray/snrm2) plus their namespace registrations, an ESLint forward-compatibility fix (context.getFilename()→context.filename), a Makefile lint-variable rename, an EditorConfig whitespace fix,format-based error messages across severaldatasets/*build scripts, and auto-generated TypeScript/docs updates. Reviewing the diff surfaced one validated, high-signal issue.Fixes, grouped by package:
blas/ext/base/gaxpblib/node_modules/@stdlib/blas/ext/base/gaxpb/test/test.main.js(line 143, introduced in b28f7b8): test description read "the function addbeta" but should read "the function addsbeta", matching the parallel phrasing already present intest.ndarray.js.Related Issues
None.
Questions
No.
Other
Validation
docs/style-guidesand compared to established reference packages (blas/ext/base/gapx,blas/base/ndarray/sdot, and siblings) by two independent reviewers.gaxpb/snrm2worked examples, test expectations, and core logic (N <= 0guard,alpha === 1.0/beta === 0.0fast paths, 5x unit-stride loop unrolling, ndarray delegation) were verified arithmetically by two independent reviewers; no runtime bugs found.snrm2package.json"squared"keyword (judgment call, not corroborated by the second reviewer), comment-backtick stylistic preferences, an alternativerepl.txtexample phrasing, and the auto-generatedchebyshevSeriesJSDoc example (// returns 0.75) whose correctness cannot be confirmed without inspecting the source package outside the diff window.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. An automated multi-agent review of the last 24 hours of commits to
developflagged the typo; the one-line fix was applied and verified by Claude Code.Generated by Claude Code