bench: rename benchmark file in @stdlib/object/none-own-by#12177
Merged
Conversation
Rename the package benchmark from `benchmark/index.js` to the canonical `benchmark/benchmark.js`. Within `@stdlib/object`, 24 of 26 members (92%) place the primary benchmark at `benchmark/benchmark.js`, and this file was the only `benchmark/index.js` among the 4332 benchmark-bearing packages in stdlib. The non-canonical name does not match the benchmark runner discovery glob (`benchmark/**/benchmark*.js`), so the benchmark was never executed; the rename restores discovery. File contents are unchanged.
Contributor
Coverage ReportNo coverage information available. |
kgryte
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request renames the benchmark file in
@stdlib/object/none-own-byfrom the non-canonicalbenchmark/index.jstobenchmark/benchmark.js, matching the convention used by 92% of the namespace.@stdlib/object/none-own-byThe package benchmark resided at
benchmark/index.js— the only file of that name among the 4332 benchmark-bearing packages in stdlib, and one of two@stdlib/objectmembers not on the 92% (24/26)benchmark/benchmark.jsconvention. stdlib discovers benchmarks via thebenchmark/**/benchmark*.jsglob, soindex.jswas silently excluded from the suite and never executed. Renaming the file tobenchmark/benchmark.jsrestores discovery and conforms to the namespace; the file contents are unchanged (a puregit mv).Related Issues
No.
Questions
No.
Other
@stdlib/object/none-own-bywas migrated from@stdlib/utils/none-own-byin #8678; the non-canonical benchmark filename predates and was carried through that migration. The finding was surfaced by extracting the file tree of all 26@stdlib/objectmembers and computing the per-feature majority at a 75% threshold, then validated by two independent review agents — a cross-reference review (no test, example,package.jsonscript, or documentation references the benchmark path) and a structural review (the directory holds a single self-contained benchmark, not an aggregator). Both returnedconfirmed-drift. Outliers reflecting genuine semantic differences (e.g.assign/for-inargument handling) and features without a clear 75% majority (public signatures, validation prologues) were deliberately excluded.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running an automated cross-package drift-detection routine. The
@stdlib/objectnamespace was selected at random; structural and semantic features were extracted from all 26 members; the per-feature majority pattern was computed at a 75% threshold; and the single drift finding that survived the pre-validation gates was reviewed by independent validation agents before the change was applied. A maintainer should audit the diff before promoting this draft.@stdlib-js/reviewers
Generated by Claude Code