Skip to content

bench: rename benchmark file in @stdlib/object/none-own-by#12177

Merged
kgryte merged 1 commit into
developfrom
claude/inspiring-curie-2PQtI
May 17, 2026
Merged

bench: rename benchmark file in @stdlib/object/none-own-by#12177
kgryte merged 1 commit into
developfrom
claude/inspiring-curie-2PQtI

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

This pull request renames the benchmark file in @stdlib/object/none-own-by from the non-canonical benchmark/index.js to benchmark/benchmark.js, matching the convention used by 92% of the namespace.

@stdlib/object/none-own-by

The package benchmark resided at benchmark/index.js — the only file of that name among the 4332 benchmark-bearing packages in stdlib, and one of two @stdlib/object members not on the 92% (24/26) benchmark/benchmark.js convention. stdlib discovers benchmarks via the benchmark/**/benchmark*.js glob, so index.js was silently excluded from the suite and never executed. Renaming the file to benchmark/benchmark.js restores discovery and conforms to the namespace; the file contents are unchanged (a pure git mv).

Related Issues

No.

Questions

No.

Other

@stdlib/object/none-own-by was migrated from @stdlib/utils/none-own-by in #8678; the non-canonical benchmark filename predates and was carried through that migration. The finding was surfaced by extracting the file tree of all 26 @stdlib/object members and computing the per-feature majority at a 75% threshold, then validated by two independent review agents — a cross-reference review (no test, example, package.json script, or documentation references the benchmark path) and a structural review (the directory holds a single self-contained benchmark, not an aggregator). Both returned confirmed-drift. Outliers reflecting genuine semantic differences (e.g. assign / for-in argument handling) and features without a clear 75% majority (public signatures, validation prologues) were deliberately excluded.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code running an automated cross-package drift-detection routine. The @stdlib/object namespace was selected at random; structural and semantic features were extracted from all 26 members; the per-feature majority pattern was computed at a 75% threshold; and the single drift finding that survived the pre-validation gates was reviewed by independent validation agents before the change was applied. A maintainer should audit the diff before promoting this draft.


@stdlib-js/reviewers


Generated by Claude Code

Rename the package benchmark from `benchmark/index.js` to the canonical
`benchmark/benchmark.js`. Within `@stdlib/object`, 24 of 26 members
(92%) place the primary benchmark at `benchmark/benchmark.js`, and this
file was the only `benchmark/index.js` among the 4332 benchmark-bearing
packages in stdlib. The non-canonical name does not match the benchmark
runner discovery glob (`benchmark/**/benchmark*.js`), so the benchmark
was never executed; the rename restores discovery. File contents are
unchanged.
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label May 17, 2026
@kgryte kgryte marked this pull request as ready for review May 17, 2026 21:17
@kgryte kgryte requested a review from a team May 17, 2026 21:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 17, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 17, 2026
@kgryte kgryte merged commit 79794ca into develop May 17, 2026
55 checks passed
@kgryte kgryte deleted the claude/inspiring-curie-2PQtI branch May 17, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants