chore: use format for error messages in strided build scripts#12178
Merged
Conversation
Propagates fix from dca1108 ("chore: use `format` for error messages in `datasets/*` build scripts") to sibling code-generation scripts that still assemble `throw new Error` messages via string concatenation. Converts `+`-concatenated error strings to `@stdlib/string/format` calls in `strided/base/binary` and `math/strided/ops/{add,sub,mul}`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-16 23:58:43 -0700 and 2026-05-17 01:31:08 -0700 to sibling packages.formatfor error messages in build scriptsPropagates
dca1108ec, which replaced+-concatenatedthrow new Errormessages withformat()calls from@stdlib/string/formatin dataset build scripts, applying the same transformation to code-generation build scripts that retained the old pattern. Each affected script gains avar format = require( '@stdlib/string/format' );declaration and uses%sspecifiers for all interpolated string values.Affected packages:
strided/base/binary—scripts/loops.jsmath/strided/ops/add—scripts/addon.jsmath/strided/ops/sub—scripts/addon.jsmath/strided/ops/mul—scripts/addon.jsRelated Issues
None.
Questions
No.
Other
Validation
*/scripts/build scripts underlib/node_modules/@stdlib/were searched forthrow new Errormessages assembled by+concatenation without an existing@stdlib/string/formatimport.%sspecifiers), the absence of anyformatidentifier collision, and that each change is self-contained within its file.docs/style-guides.node --checkand aformat()output-equivalence check were run on all four files.dff4820f3(dtslintAccessorArraytype expectations) ande31cdb769(context.getFilename()→context.filename) — repository-wide searches returned zero remaining sites.87731b41d(markdown-lint Makefile variable rename) — no dangling references to the old names and no sibling Makefiles with the analogous misnaming.10cef3dde(EditorConfig indentation) — formatting conformance with no behavioral or user-visible defect; out of scope for fix propagation.b2eb5da5b(staleis-typed-array"See Also" description) — the candidate text resides in the auto-populated<section class="related">block marked "Do not manually edit"; the fix belongs to the related-packages generator, not manual edits.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running an automated fix-propagation routine: it reviewed the last 24 hours of commits merged to
develop, identifieddca1108ecas a generalizable fix, located sibling build scripts carrying the same defect, validated each candidate site with independent review agents, and applied the equivalent change.Generated by Claude Code