chore: correct issues found during recent develop commit review#12201
Merged
Conversation
The `commit-hooks` npm configuration key was misspelled as `commits-hooks`, and the `min-release-age` directive used a colon instead of an `=` separator. As written, npm silently ignores both settings, so neither the commit hooks nor the minimum release-age guard take effect.
The native entry points in `saxpb.native.js` and `ndarray.native.js` are module-level exported functions and should not be tagged `@private`. The sibling `daxpb` package and the `dapx` reference package omit the tag on the corresponding files.
develop commit review
develop commit reviewdevelop commit review
kgryte
approved these changes
May 19, 2026
Member
|
In the CI failure, the addon successfully built locally, so I will go ahead and merge this PR, as the failure does not appear to be related to changes introduced here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-05-18 16:46:06 -0700 and 2026-05-19 04:22:25 -0700.Description
This pull request applies follow-up corrections for validated, high-signal issues identified while reviewing the 13 commits merged to
developin the window above (7fab4532...e1d7dc74).That window covered: two new BLAS extension packages (
blas/ext/base/daxpb,blas/ext/base/saxpb) with their namespace and TypeScript wiring; ablas/base/cgemvbug-and-typo fix; addedα/βtests forblas/base/ggemm; doc/grammar propagation across thegindex-of-column/sindex-of-columnsiblings; anndarray/basebenchmark refactor to string interpolation (~200 files); and an.npmrcconfiguration update.This pull request fixes the following, grouped by package. Each group is a separate commit (
fix:for the configuration bugs,style:for the JSDoc tag removal):.npmrccommit-hookswas misspelled ascommits-hooks(e1d7dc74). npm silently ignores the unrecognized key, so git commit hooks would not run duringnpm version. Corrected the spelling.min-release-ageused a colon separator —min-release-age: 90(e1d7dc74)..npmrcis INI-format and requires=; every other directive uses it, and with a colon npm does not parse the directive, so the minimum release-age supply-chain guard never takes effect. Changed tomin-release-age = 90.blas/ext/base/saxpblib/saxpb.native.js(103392c9) carried a spurious@privateJSDoc tag on the exported native function — a public entry point, not an internal helper. Removed the tag to match the siblingdaxpbpackage and thedapxreference.lib/ndarray.native.js(103392c9) likewise tagged the exported native ndarray interface@private. Removed the tag to matchdaxpbanddapx.Related Issues
None.
Questions
No.
Other
This pull request is the output of an automated review of the last 24 hours of
develop. Four reviewer agents — two for stdlib code-style compliance, two for bugs/correctness — independently audited the window's diff; findings were cross-checked, and only issues re-verifiable directly against the diff (and the relevant stdlib reference packages) were retained.Validation — checked, no action required:
blas/base/cgemv(c606f03c): theLDA < v→LDA < valacorrection, thecfill_ndarrayzero-argument fix, and thestrideA2JSDoc/grammar fixes are all genuine and correct.blas/base/ggemmtests (fc3275c0): the new fixtures'C_outvalues verified arithmetically (α*A*B + β*C).daxpb/saxpb: README, REPL, and JSDoc numeric examples verified (x[i] = α*x[i] + β); C sources, addons, and manifests internally consistent.ndarray/basebenchmark refactor (7fab4532,9330de70): theformat()conversions preserve the original concatenated strings; format-specifier counts match argument counts.Deliberately excluded (out of scope / requires interpretation): the
daxpb/saxpbndarray JSDoc descriptions differ slightly in whether they include the phrase "using alternative indexing semantics" — a wording inconsistency with no governing style-guide rule, left for maintainer judgment. Auto-generated bot commits (REPL data, namespace ToC, TypeScript declarations) were not line-reviewed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was generated by an automated multi-agent review of commits merged to
developover the preceding 24 hours, run with Claude Code. Reviewer agents flagged candidate issues; each retained fix was independently verified against the diff and the relevant stdlib reference packages before being applied. This is a draft — a human maintainer should audit before promoting it.Generated by Claude Code