chore: propagate typo and doc-note fixes across blas sibling packages#12202
Merged
Conversation
Propagates fixes from c606f03 ("fix: correct bugs and typos in `blas/base/cgemv`") to sibling packages exhibiting the same defects. Removes the ungrammatical article from the `strideX` validation error message ("must be a nonzero" -> "must be nonzero") in the `dsyr` and `ssyr` ndarray C implementations, and corrects transposed words in the ndarray interface description ("indexing alternative semantics" -> "alternative indexing semantics") in the `dgemv` and `sgemv` READMEs.
Propagates the doc-note fix from 2384460 ("docs: propagate recent doc-note and grammar fixes to sibling packages") to the remaining `*index-of-row` and `*last-index-of-row` sibling packages. Each `## Notes` block stated the function returns `-1` when "unable to find a search vector"; the search vector is the caller-provided query, not the value being located. Aligns the phrasing with the analogous `*index-of-column` fix by replacing it with "unable to find a matching row" across the affected `lib/` implementations and TypeScript declaration files.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
blas sibling packagesblas sibling packages
kgryte
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-18 and 2026-05-19 to sibling packages.Error-message grammar typo (
fix:)c606f03c3("fix: correct bugs and typos inblas/base/cgemv") removed an ungrammatical article from a stride-validation error message. The same defect —must be a nonzeroin place ofmust be nonzero— is present in thestrideX == 0guard of two sibling ndarray C implementations:@stdlib/blas/base/dsyr@stdlib/blas/base/ssyrTransposed words in ndarray interface description (
fix:)c606f03c3also corrected a word-order error in thecgemvREADME. The*_ndarrayinterface description in two sibling READMEs readsusing indexing alternative semanticsrather thanusing alternative indexing semantics:@stdlib/blas/base/dgemv@stdlib/blas/base/sgemvReturn-value doc-note phrasing (
docs:)238446093("docs: propagate recent doc-note and grammar fixes to sibling packages") fixed the## Notesblock of the*index-of-columnpackages, which claimed the function returns-1when "unable to find a search vector". The search vector is the caller-provided query, not the value being located; the function returns-1when unable to find a matching column. The analogous*index-of-rowand*last-index-of-rowpackages carry the identical defect, corrected here to "unable to find a matching row" acrosslib/implementations and TypeScript declaration files:@stdlib/blas/ext/base/cindex-of-row,dindex-of-row,gindex-of-row,sindex-of-row,zindex-of-row@stdlib/blas/ext/base/clast-index-of-row,dlast-index-of-row,glast-index-of-row,slast-index-of-row,zlast-index-of-rowRelated Issues
None.
Questions
No.
Other
Validation: each pattern was located by searching the originating commit's defect signature across sibling packages under the same namespace. Candidate sites were verified by two independent reviews — each reading every target file in full to confirm the defect is present and the surrounding context does not change the semantics — followed by a style-consistency pass confirming each edit is a pure phrase substitution introducing no formatting drift.
Deliberately excluded:
test/*.js) and theblas/ext/basenamespace declaration barrel, mirroring the file scope of source commit238446093(lib/and per-packagedocs/types/only).cgemvlogic fixes fromc606f03c3(LDA < v→LDA < vala; thebeta == 0zero-fill argument; the duplicate@param strideA1): thedgemv/sgemv/ggemvsiblings were inspected and are already correct — those defects were unique to the newly addedcgemv.bench:string-interpolation refactors and thetest:coverage additions merged in the same window: stylistic and additive changes, not defect corrections.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by an automated fix-propagation routine run with Claude Code. The routine identified generalizable fixes among commits merged to
developin the preceding 24 hours, located sibling packages exhibiting the same defect, and applied the equivalent change at each validated site. Every site was confirmed by independent automated review passes before inclusion.@stdlib-js/reviewers
Generated by Claude Code