Skip to content

chore: propagate typo and doc-note fixes across blas sibling packages#12202

Merged
kgryte merged 2 commits into
developfrom
claude/wonderful-planck-mXrji
May 19, 2026
Merged

chore: propagate typo and doc-note fixes across blas sibling packages#12202
kgryte merged 2 commits into
developfrom
claude/wonderful-planck-mXrji

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Propagating fixes merged to develop between 2026-05-18 and 2026-05-19 to sibling packages.

Error-message grammar typo (fix:)

c606f03c3 ("fix: correct bugs and typos in blas/base/cgemv") removed an ungrammatical article from a stride-validation error message. The same defect — must be a nonzero in place of must be nonzero — is present in the strideX == 0 guard of two sibling ndarray C implementations:

  • @stdlib/blas/base/dsyr
  • @stdlib/blas/base/ssyr

Transposed words in ndarray interface description (fix:)

c606f03c3 also corrected a word-order error in the cgemv README. The *_ndarray interface description in two sibling READMEs reads using indexing alternative semantics rather than using alternative indexing semantics:

  • @stdlib/blas/base/dgemv
  • @stdlib/blas/base/sgemv

Return-value doc-note phrasing (docs:)

238446093 ("docs: propagate recent doc-note and grammar fixes to sibling packages") fixed the ## Notes block of the *index-of-column packages, which claimed the function returns -1 when "unable to find a search vector". The search vector is the caller-provided query, not the value being located; the function returns -1 when unable to find a matching column. The analogous *index-of-row and *last-index-of-row packages carry the identical defect, corrected here to "unable to find a matching row" across lib/ implementations and TypeScript declaration files:

  • @stdlib/blas/ext/base/cindex-of-row, dindex-of-row, gindex-of-row, sindex-of-row, zindex-of-row
  • @stdlib/blas/ext/base/clast-index-of-row, dlast-index-of-row, glast-index-of-row, slast-index-of-row, zlast-index-of-row

Related Issues

None.

Questions

No.

Other

Validation: each pattern was located by searching the originating commit's defect signature across sibling packages under the same namespace. Candidate sites were verified by two independent reviews — each reading every target file in full to confirm the defect is present and the surrounding context does not change the semantics — followed by a style-consistency pass confirming each edit is a pure phrase substitution introducing no formatting drift.

Deliberately excluded:

  • Test files (test/*.js) and the blas/ext/base namespace declaration barrel, mirroring the file scope of source commit 238446093 (lib/ and per-package docs/types/ only).
  • The cgemv logic fixes from c606f03c3 (LDA < vLDA < vala; the beta == 0 zero-fill argument; the duplicate @param strideA1): the dgemv/sgemv/ggemv siblings were inspected and are already correct — those defects were unique to the newly added cgemv.
  • The bench: string-interpolation refactors and the test: coverage additions merged in the same window: stylistic and additive changes, not defect corrections.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was produced by an automated fix-propagation routine run with Claude Code. The routine identified generalizable fixes among commits merged to develop in the preceding 24 hours, located sibling packages exhibiting the same defect, and applied the equivalent change at each validated site. Every site was confirmed by independent automated review passes before inclusion.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits May 19, 2026 13:20
Propagates fixes from c606f03 ("fix: correct bugs and typos in
`blas/base/cgemv`") to sibling packages exhibiting the same defects.

Removes the ungrammatical article from the `strideX` validation error
message ("must be a nonzero" -> "must be nonzero") in the `dsyr` and
`ssyr` ndarray C implementations, and corrects transposed words in the
ndarray interface description ("indexing alternative semantics" ->
"alternative indexing semantics") in the `dgemv` and `sgemv` READMEs.
Propagates the doc-note fix from 2384460 ("docs: propagate recent
doc-note and grammar fixes to sibling packages") to the remaining
`*index-of-row` and `*last-index-of-row` sibling packages.

Each `## Notes` block stated the function returns `-1` when "unable to
find a search vector"; the search vector is the caller-provided query,
not the value being located. Aligns the phrasing with the analogous
`*index-of-column` fix by replacing it with "unable to find a matching
row" across the affected `lib/` implementations and TypeScript
declaration files.
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 19, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/dgemv $\color{red}748/749$
$\color{green}+99.87%$
$\color{red}116/117$
$\color{green}+99.15%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{red}748/749$
$\color{green}+99.87%$
blas/base/dsyr $\color{green}616/616$
$\color{green}+100.00%$
$\color{green}82/82$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}616/616$
$\color{green}+100.00%$
blas/base/sgemv $\color{red}750/751$
$\color{green}+99.87%$
$\color{red}116/117$
$\color{green}+99.15%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{red}750/751$
$\color{green}+99.87%$
blas/base/ssyr $\color{green}616/616$
$\color{green}+100.00%$
$\color{green}82/82$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}616/616$
$\color{green}+100.00%$
blas/ext/base/cindex-of-row $\color{green}548/548$
$\color{green}+100.00%$
$\color{green}54/54$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}548/548$
$\color{green}+100.00%$
blas/ext/base/clast-index-of-row $\color{green}601/601$
$\color{green}+100.00%$
$\color{green}52/52$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}601/601$
$\color{green}+100.00%$
blas/ext/base/dindex-of-row $\color{green}531/531$
$\color{green}+100.00%$
$\color{green}52/52$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}531/531$
$\color{green}+100.00%$
blas/ext/base/dlast-index-of-row $\color{green}575/575$
$\color{green}+100.00%$
$\color{green}50/50$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}575/575$
$\color{green}+100.00%$
blas/ext/base/gindex-of-row $\color{red}471/555$
$\color{green}+84.86%$
$\color{red}39/40$
$\color{green}+97.50%$
$\color{red}3/4$
$\color{green}+75.00%$
$\color{red}471/555$
$\color{green}+84.86%$
blas/ext/base/glast-index-of-row $\color{green}555/555$
$\color{green}+100.00%$
$\color{green}56/56$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}555/555$
$\color{green}+100.00%$
blas/ext/base/sindex-of-row $\color{green}531/531$
$\color{green}+100.00%$
$\color{green}52/52$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}531/531$
$\color{green}+100.00%$
blas/ext/base/slast-index-of-row $\color{green}575/575$
$\color{green}+100.00%$
$\color{green}50/50$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}575/575$
$\color{green}+100.00%$
blas/ext/base/zindex-of-row $\color{green}548/548$
$\color{green}+100.00%$
$\color{green}54/54$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}548/548$
$\color{green}+100.00%$
blas/ext/base/zlast-index-of-row $\color{green}601/601$
$\color{green}+100.00%$
$\color{green}52/52$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}601/601$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title fix: propagate typo and doc-note fixes across blas sibling packages chore: propagate typo and doc-note fixes across blas sibling packages May 19, 2026
@Planeshifter Planeshifter marked this pull request as ready for review May 19, 2026 16:47
@Planeshifter Planeshifter requested a review from a team May 19, 2026 16:47
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 19, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 19, 2026
@kgryte kgryte merged commit 9559de0 into develop May 19, 2026
59 checks passed
@kgryte kgryte deleted the claude/wonderful-planck-mXrji branch May 19, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants