feat: add C implementation for math/base/special/dirichlet-eta

[gunjjoshi]

Progresses #649.

Description

What is the purpose of this pull request?

This pull request:

• adds the C implementation for math/base/special/dirichlet-eta.

double stdlib_base_eta( const double s )

Related Issues

Does this pull request have any related issues?

This pull request:

• progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/dirichlet-eta	$\color{green}185/185$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}185/185$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[gunjjoshi]

We get the same lint error here as well, that came at: https://github.com/stdlib-js/stdlib/actions/runs/12022789799/job/33515586260#step:17:1332

[gunjjoshi]

It seems that this might be due to different function names, such as we use dirichlet_eta.h for the header file, and stdlib_base_eta, instead of stdlib_base_dirichlet_eta for the main function. The same error is encountered in riemann-zeta, where we use riemann_zeta.h and stdlib_base_zeta.

[gunjjoshi]

It seems that this might be due to different function names, such as we use dirichlet_eta.h for the header file, and stdlib_base_eta, instead of stdlib_base_dirichlet_eta for the main function. The same error is encountered in riemann-zeta, where we use riemann_zeta.h and stdlib_base_zeta.

Okay, I tried changing the C implementation to use stdlib_base_dirichlet_eta instead of stdlib_base_eta, but that didn't work.

[Copilot]

Copilot reviewed 21 out of 21 changed files in this pull request and generated no suggestions.

[Planeshifter]

/stdlib merge

[Planeshifter]

@gunjjoshi Encountered the same issue in a different PR. Problem should go away after updating the package.json file.

@stdlib/_tools/pkgs/includes, which is used to generate the includes list used by cppcheck via our make recipes, expects the include directory to be set in the package.json directories:

  "gypfile": true,
  "directories": {
    "benchmark": "./benchmark",
    "doc": "./docs",
    "example": "./examples",
    "include": "./include",
    "lib": "./lib",
    "scripts": "./scripts",
    "src": "./src",
    "test": "./test"
  },

We should add a lint check for whether "directories" and gypfile is properly populated in the package.json and raise an error if not. This could be done by invoking the same scripts as in https://github.com/stdlib-js/stdlib/blob/develop/.github/workflows/update_package_meta_data.yml and then simply erroring in case there are changes (could check e.g. via if [[ git status --porcelain ]]; then).

cc @kgryte

[Planeshifter]

/stdlib merge

[Planeshifter]

/stdlib merge

[gunjjoshi]

@Planeshifter That worked. Thanks!

[Planeshifter]

LGTM!

[kgryte]

@stdlib/_tools/pkgs/includes, which is used to generate the includes list used by cppcheck via our make recipes, expects the include directory to be set in the package.json

Thanks for tracking this down, @Planeshifter! And agreed. Thanks for setting up linting to catch this in the future.