Skip to content

feat: add stats/base/dists/planck/mean#3942

Merged
kgryte merged 6 commits into
stdlib-js:developfrom
Jaysukh-409:planck-mean
Dec 25, 2024
Merged

feat: add stats/base/dists/planck/mean#3942
kgryte merged 6 commits into
stdlib-js:developfrom
Jaysukh-409:planck-mean

Conversation

@Jaysukh-409
Copy link
Copy Markdown
Member

@Jaysukh-409 Jaysukh-409 commented Dec 16, 2024

Description

What is the purpose of this pull request?

This pull request:

  • Adds the mean for the Planck Discrete Random Variable.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Dec 16, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/planck/mean $\color{green}108/108$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}108/108$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Dec 18, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/README.md Outdated
kgryte
kgryte reviewed Dec 18, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/README.md Outdated
kgryte
kgryte reviewed Dec 18, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/README.md Outdated
kgryte
kgryte reviewed Dec 18, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/benchmark/benchmark.js Outdated
kgryte
kgryte requested changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the same requested changes in #3896 are applicable here.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 18, 2024
@Jaysukh-409
Copy link
Copy Markdown
Member Author

Jaysukh-409 commented Dec 18, 2024

If generating rv doesn't need changes then this PR is ready to merge.

kgryte
kgryte reviewed Dec 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/benchmark/benchmark.js Outdated
kgryte
kgryte reviewed Dec 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/examples/index.js Outdated
kgryte
kgryte reviewed Dec 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/lib/main.js Outdated
kgryte
kgryte reviewed Dec 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/lib/main.js Outdated
kgryte
kgryte reviewed Dec 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/test/fixtures/python/REQUIRE Outdated
kgryte
kgryte reviewed Dec 19, 2024
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/mean/test/fixtures/python/runner.py Outdated
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 19, 2024

/stdlib merge

kgryte
kgryte requested changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another round of review comments.

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 19, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 19, 2024
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Dec 19, 2024

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 19, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 19, 2024
@Jaysukh-409 Jaysukh-409 requested a review from kgryte December 19, 2024 05:32
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 19, 2024
@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Dec 25, 2024
kgryte
kgryte approved these changes Dec 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now LGTM. Thanks for working on this @Jaysukh-409.

@kgryte kgryte merged commit 56801e8 into stdlib-js:develop Dec 25, 2024
@kgryte kgryte deleted the planck-mean branch December 25, 2024 10:46
@kgryte kgryte mentioned this pull request Dec 25, 2024
Merged
1 task
@yuvimittal yuvimittal mentioned this pull request Jan 26, 2025
Closed
3 tasks
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Jaysukh-409 @kgryte
@stdlib-bot @ShabiShett07
feat: add stats/base/dists/planck/mean
a34ac9d 
PR-URL: stdlib-js#3942
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jaysukh-409 @stdlib-bot @kgryte