feat: add C implementation for stats/base/dists/kumaraswamy/median#4020
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
stats/base/dists/kumaraswamy/median
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for opening a PR!
Unfortunately, it right now contains a large number of errors that will have to be addressed before it can move forward.
|
Thanks for the review, This is my first time contributing to open source, |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
@DeshDeepakKant Thanks for all the changes! Did another review and, after a few more edits, I believe your PR should be ready to land now. This is an exciting milestone, as it marks your first contribution to open-source development. Let's go ahead and merge your contribution. 🚀 |
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
PR-URL: stdlib-js#4020 Closes: stdlib-js#3701 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Resolves #3701
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/kumaraswamy/median#3701Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers