feat: add C implementation for `stats/base/dists/signrank/pdf` by Lokeshranjan8 · Pull Request #4637 · stdlib-js/stdlib

Lokeshranjan8 · 2025-01-07T18:05:22Z

Resolves #3884

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for stats/base/dists/signrank/pdf along with relevant docs, tests, examples and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/signrank/pdf #3884

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-01-07T18:05:55Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot · 2025-01-07T18:07:56Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/signrank/pdf	$\color{red}358/360$ $\color{green}+99.44\%$	$\color{red}36/37$ $\color{green}+97.30\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{red}358/360$ $\color{green}+99.44\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

…t.json Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

…ive.js Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter

LGTM! Thanks, @Lokeshranjan8!

stdlib-bot · 2025-07-11T18:57:14Z

PR Commit Message

feat: add C implementation for `stats/base/dists/signrank/pdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4637
Closes: https://github.com/stdlib-js/stdlib/issues/3884

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 7, 2025

Planeshifter changed the title ~~feat: add c implementation for stats/base/dists/signrank/pdf~~ feat: add implementation for stats/base/dists/signrank/pdf Jan 8, 2025

Planeshifter changed the title ~~feat: add implementation for stats/base/dists/signrank/pdf~~ feat: add C implementation for stats/base/dists/signrank/pdf Jan 8, 2025

Planeshifter changed the title ~~feat: add C implementation for stats/base/dists/signrank/pdf~~ feat: add C implementation for stats/base/dists/signrank/pdf Jun 22, 2025

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 22, 2025

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/src/addon.c Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/benchmark/benchmark.js Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/src/main.c Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/src/main.c Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/manifest.json Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/manifest.json Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/manifest.json Outdated

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/lib/native.js Outdated

Planeshifter and others added 9 commits July 11, 2025 09:26

Apply suggestion from @Planeshifter

3030fda

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Apply suggestion from @Planeshifter

86ef6b7

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Update lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/manifes…

de34d5c

…t.json Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Update lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/manifes…

b7cd111

…t.json Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Update lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/manifes…

12b9451

…t.json Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Update lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/lib/nat…

cbca601

…ive.js Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Lokeshranjan8 force-pushed the signrank-pdf branch from 8e8a4a9 to ceb625c Compare July 11, 2025 04:53

Update benchmark.native.js

0a27f62

Signed-off-by: Lokesh Ranjan <lokesh.ranjan.phe23@itbhu.ac.in>

Lokeshranjan8 requested a review from Planeshifter July 11, 2025 06:34

Planeshifter reviewed Jul 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/signrank/pdf/benchmark/benchmark.js Outdated

chore: keep original copyright year

713cdaf

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter approved these changes Jul 11, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 11, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 11, 2025

Planeshifter merged commit e6823fe into stdlib-js:develop Jul 11, 2025
29 checks passed

Lokeshranjan8 mentioned this pull request Mar 20, 2026

[RFC]: Implement strided implementations of statistical hypothesis tests stdlib-js/google-summer-of-code#192

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add C implementation for `stats/base/dists/signrank/pdf`#4637

feat: add C implementation for `stats/base/dists/signrank/pdf`#4637
Planeshifter merged 13 commits into
stdlib-js:developfrom
Lokeshranjan8:signrank-pdf

Lokeshranjan8 commented Jan 7, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Jan 7, 2025

Uh oh!

stdlib-bot commented Jan 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jul 11, 2025 •

edited by Planeshifter

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Lokeshranjan8 commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jan 7, 2025

Uh oh!

stdlib-bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jul 11, 2025 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lokeshranjan8 commented Jan 7, 2025 •

edited

Loading

stdlib-bot commented Jan 7, 2025 •

edited

Loading

stdlib-bot commented Jul 11, 2025 •

edited by Planeshifter

Loading