Skip to content

feat: add C implementation for stats/base/dists/planck/median#4938

Merged
Planeshifter merged 4 commits into
stdlib-js:developfrom
yuvimittal:feature/planck-median
Feb 15, 2025
Merged

feat: add C implementation for stats/base/dists/planck/median#4938
Planeshifter merged 4 commits into
stdlib-js:developfrom
yuvimittal:feature/planck-median

Conversation

@yuvimittal
Copy link
Copy Markdown
Contributor

@yuvimittal yuvimittal commented Jan 28, 2025

Resolves #4937

Description

What is the purpose of this pull request?

This pull request:

  • Add C implementation for @stdlib/stats/base/dists/planck/median

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@yuvimittal
Add C implementation for @stdlib/stats/base/dists/planck/median
df8e320 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvimittal yuvimittal changed the title Add C implementation for @stdlib/stats/base/dists/planck/median feat: Add C implementation for @stdlib/stats/base/dists/planck/median Jan 29, 2025
@yuvimittal yuvimittal changed the title feat: Add C implementation for @stdlib/stats/base/dists/planck/median feat: Add C implementation for @stdlib/stats/base/dists/planck/median Jan 29, 2025
@yuvimittal yuvimittal changed the title feat: Add C implementation for @stdlib/stats/base/dists/planck/median feat: add C implementation for stats/base/dists/planck/median Feb 2, 2025
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Feb 2, 2025
@yuvimittal
Refactor random number generation in JS benchmarks
00e41f6 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/planck/median $\color{green}163/163$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}163/163$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Feb 15, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Feb 15, 2025
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Feb 15, 2025
@Planeshifter Planeshifter self-requested a review February 15, 2025 22:53
Planeshifter
Planeshifter reviewed Feb 15, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/median/README.md Outdated
Planeshifter
Planeshifter reviewed Feb 15, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.native.js Outdated
Planeshifter
Planeshifter reviewed Feb 15, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/median/src/main.c Outdated
Planeshifter
Planeshifter reviewed Feb 15, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/planck/median/src/main.c Outdated
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 15, 2025
@Planeshifter
chore: apply suggestions from code review
6bd6efb 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Feb 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small errors with respect to missing spaces and such, but otherwise PR is in great shape! Will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 15, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 15, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 15, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation for `stats/base/dists/planck/median`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4938
Closes: https://github.com/stdlib-js/stdlib/issues/4937

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit fb90f93 into stdlib-js:develop Feb 15, 2025
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@yuvimittal @Planeshifter
@stdlib-bot @ShabiShett07
feat: add C implementation for stats/base/dists/planck/median
3e71413 
PR-URL: stdlib-js#4938
Closes: stdlib-js#4937

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/planck/median

3 participants

@yuvimittal @stdlib-bot @Planeshifter