bench: refactor random number generation in JS benchmarks for stats/b… by yaswanthkosuru · Pull Request #5157 · stdlib-js/stdlib

yaswanthkosuru · 2025-02-10T03:32:43Z

Resolves 4976

Description

What is the purpose of this pull request?

This pull request:

Refactor random number generation in JS benchmarks for stats/base/dists/laplace

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/laplace #4976

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…ase/dists/laplace --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-02-10T03:33:50Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/laplace/cdf	$\color{green}222/222$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}222/222$ $\color{green}+100.00\%$
stats/base/dists/laplace/ctor	$\color{green}488/488$ $\color{green}+100.00\%$	$\color{green}36/36$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}488/488$ $\color{green}+100.00\%$
stats/base/dists/laplace/entropy	$\color{green}177/177$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}177/177$ $\color{green}+100.00\%$
stats/base/dists/laplace/kurtosis	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/laplace/logcdf	$\color{green}222/222$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}222/222$ $\color{green}+100.00\%$
stats/base/dists/laplace/logpdf	$\color{green}219/219$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}219/219$ $\color{green}+100.00\%$
stats/base/dists/laplace/mean	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/laplace/median	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/laplace/mgf	$\color{green}236/236$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}236/236$ $\color{green}+100.00\%$
stats/base/dists/laplace/mode	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/laplace/pdf	$\color{green}218/218$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}218/218$ $\color{green}+100.00\%$
stats/base/dists/laplace/quantile	$\color{green}222/222$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}222/222$ $\color{green}+100.00\%$
stats/base/dists/laplace/skewness	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/laplace/stdev	$\color{green}176/176$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}176/176$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

…stats/base/dists/laplace --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

yaswanthkosuru · 2025-02-10T12:17:56Z

@Planeshifter Ready for review

anandkaranubc · 2025-02-10T18:05:14Z

+	scale = new Float64Array( len );
+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( -100.0, 200.0 );


Suggested change

x[ i ] = uniform( -100.0, 200.0 );

x[ i ] = uniform( -100.0, 100.0 );

The range remains the same as original

anandkaranubc · 2025-02-10T18:05:32Z

+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( -100.0, 200.0 );
+		mu[ i ] = uniform( -50.0, 100.0 );


Suggested change

mu[ i ] = uniform( -50.0, 100.0 );

mu[ i ] = uniform( -50.0, 50.0 );

Same comment as above.

anandkaranubc · 2025-02-10T18:06:10Z

+	len = 100;
+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( -2.0, 4 );


Suggested change

x[ i ] = uniform( -2.0, 4 );

x[ i ] = uniform( -2.0, 2.0 );

This change (to keep the same original range) applies throughout the PR.

anandkaranubc · 2025-02-10T18:06:40Z

 	var b;
 	var i;

+	len=100;


Suggested change

len=100;

len = 100;

anandkaranubc · 2025-02-10T18:08:09Z

 	mu = 2.0;
 	b = 3.0;
+	len = 100;
+	y = new Array( len );


Suggested change

y = new Array( len );

y = new Float64Array( len );

This change applies throughout the PR. Use Float64Array instead of Array

anandkaranubc · 2025-02-10T18:09:01Z

 	dist = new Laplace( mu, b );
+	len = 100;
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( -3.0, 6.0 );


Suggested change

x[ i ] = uniform( -3.0, 6.0 );

x[ i ] = uniform( -3.0, 3.0 );

anandkaranubc · 2025-02-10T18:09:42Z

 	for ( i = 0; i < len; i++ ) {
-		mu[ i ] = ( randu() * 100.0 ) - 50.0;
-		scale[ i ] = ( randu() * 20.0 ) + EPS;
+		mu[ i ] = uniform( -50.0, 100.0 );


Suggested change

mu[ i ] = uniform( -50.0, 100.0 );

mu[ i ] = uniform( -50.0, 50.0 );

stdlib-bot · 2025-06-22T23:33:03Z

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 10, 2025

yaswanthkosuru marked this pull request as draft February 10, 2025 05:40

stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 10, 2025

yaswanthkosuru marked this pull request as ready for review February 10, 2025 12:18

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 10, 2025

anandkaranubc requested changes Feb 10, 2025

View reviewed changes

anandkaranubc added the Needs Changes Pull request which needs changes before being merged. label Feb 10, 2025

anandkaranubc mentioned this pull request Feb 10, 2025

bench: refactor random number generation in JS benchmarks for stats/b… #5158

Closed

1 task

Planeshifter added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Jun 22, 2025

stdlib-bot closed this Jun 22, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bench: refactor random number generation in JS benchmarks for stats/b…#5157

bench: refactor random number generation in JS benchmarks for stats/b…#5157
yaswanthkosuru wants to merge 2 commits into
stdlib-js:developfrom
yaswanthkosuru:dists/laplace

yaswanthkosuru commented Feb 10, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Feb 10, 2025 •

edited

Loading

Uh oh!

yaswanthkosuru commented Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Uh oh!

stdlib-bot commented Jun 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	x[ i ] = uniform( -100.0, 200.0 );
	x[ i ] = uniform( -100.0, 100.0 );

	mu[ i ] = uniform( -50.0, 100.0 );
	mu[ i ] = uniform( -50.0, 50.0 );

	x[ i ] = uniform( -3.0, 6.0 );
	x[ i ] = uniform( -3.0, 3.0 );

Uh oh!

Conversation

yaswanthkosuru commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

yaswanthkosuru commented Feb 10, 2025

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yaswanthkosuru commented Feb 10, 2025 •

edited

Loading

stdlib-bot commented Feb 10, 2025 •

edited

Loading