bench: refactor random number generation in `stats/base/dists/studentized-range` by hrshya · Pull Request #5175 · stdlib-js/stdlib

hrshya · 2025-02-10T16:15:18Z

type: pre_push_report
description: Results of running various checks prior to pushing changes. report:

task: run_javascript_examples status: na
task: run_c_examples status: na
task: run_cpp_examples status: na
task: run_javascript_readme_examples status: na
task: run_c_benchmarks status: na
task: run_cpp_benchmarks status: na
task: run_fortran_benchmarks status: na
task: run_javascript_benchmarks status: na
task: run_julia_benchmarks status: na
task: run_python_benchmarks status: na
task: run_r_benchmarks status: na
task: run_javascript_tests status: na ---

Resolves #4987

Description

What is the purpose of this pull request?

This pull request:

Fix the random number generation operation by moving it out of the benchmarking loops and initializing it beforehand to avoid interfering with the results. [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/studentized-range #4987

Related Issues

Does this pull request have any related issues?

This pull request:

performs changes similar to bench: refactor random number generation in stats/base/dists/beta #4837 bench: refactor random number generation in stats/base/dists/hypergeometric #4955

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

stdlib-bot · 2025-02-10T16:24:43Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/studentized-range/cdf	$\color{red}649/709$ $\color{green}+91.54\%$	$\color{red}68/85$ $\color{green}+80.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{red}649/709$ $\color{green}+91.54\%$
stats/base/dists/studentized-range/quantile	$\color{red}546/580$ $\color{green}+94.14\%$	$\color{red}64/80$ $\color{green}+80.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{red}546/580$ $\color{green}+94.14\%$

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-02-10T18:40:39Z

+	q = uniform( 0.0, 12.0 );
+	r = uniform( 2.0, 20.0 );
+	v = uniform( 2.0, 20.0 );


Here, q, r, and v should each be a Float64Array of length 100 and should be initialized in a loop. Reference PRs will help.

anandkaranubc · 2025-02-10T18:41:16Z

+	q = uniform( 0.0, 12.0 );
+	r = uniform( 2.0, 20.0 );
+	v = uniform( 2.0, 20.0 );
+	y = cdf( q, r, v );


This should still remain in the benchmarking loop, as it is the part being benchmarked.

anandkaranubc · 2025-02-10T18:41:29Z

+	q = uniform( 0.0, 1.0 );
+	y = mycdf( q );


Same comment as above and applies throughout the PR.

Is this the right approach ?

Yes, considering you are using the correct range for random number generation.

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

hrshya · 2025-02-11T12:17:52Z

I have made the changes. Can you please review it.

anandkaranubc · 2025-02-11T16:39:03Z

+		p[i] = uniform( 0.0, 1.0 );
+		r[i] = uniform( 2.0, 20.0 );
+		v[i] = uniform( 2.0, 20.0 );


Same comment as above, and applies throughout the PR

…f/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

anandkaranubc

Just some minor changes; the rest of the PR looks ready for merge. Great work!

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

hrshya · 2025-02-17T10:47:39Z

Hi @anandkaranubc , Can you pls review it.

anandkaranubc · 2025-02-17T17:41:19Z

Hi @anandkaranubc , Can you pls review it.

On it!

anandkaranubc · 2025-02-17T17:44:06Z

/stdlib lint-autofix

anandkaranubc

Just some minor changes. Rest, the PR looks good!

anandkaranubc · 2025-02-17T17:56:58Z

 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pkg = require( './../package.json' ).name;
 var quantile = require( './../lib' );
+var uniform = require('@stdlib/random/base/uniform');
+var Float64Array = require( '@stdlib/array/float64' );


Suggested change

var isnan = require( '@stdlib/math/base/assert/is-nan' );

var pkg = require( './../package.json' ).name;

var quantile = require( './../lib' );

var uniform = require('@stdlib/random/base/uniform');

var Float64Array = require( '@stdlib/array/float64' );

var isnan = require( '@stdlib/math/base/assert/is-nan' );

var uniform = require( '@stdlib/random/base/uniform' );

var Float64Array = require( '@stdlib/array/float64' );

var pkg = require( './../package.json' ).name;

var quantile = require( './../lib' );

Just some rearrangement for consistency.

…f/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

anandkaranubc · 2025-02-17T18:27:23Z

/stdlib lint-autofix

anandkaranubc · 2025-02-17T18:32:02Z

@hrshya Can you also change the title to:

bench: refactor random number generation in stats/base/dists/studentized-range

Make sure you apply backticks around stats/base/dists/studentized-range

hrshya · 2025-02-17T18:36:19Z

@anandkaranubc Done!

anandkaranubc

Great work! Time to wait for a maintainer to merge this PR :)

stdlib-bot · 2025-02-17T18:46:12Z

PR Commit Message

bench: refactor random number generation in `stats/base/dists/studentized-range`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5175
Closes: https://github.com/stdlib-js/stdlib/issues/4837
Closes: https://github.com/stdlib-js/stdlib/issues/4987
Ref: https://github.com/stdlib-js/stdlib/issues/4955

Co-authored-by: Harsh <149176984+hrshya@users.noreply.github.com>
Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Co-authored-by: hrshya <harshyadav6078@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: anandkaranubc <anandkaranubc@users.noreply.github.com>
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

Planeshifter · 2025-02-17T18:46:52Z

Thanks @hrshya for PR and @anandkaranubc for review; much appreciated!

stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 10, 2025

stdlib-bot reviewed Feb 10, 2025

View reviewed changes

anandkaranubc requested changes Feb 10, 2025

View reviewed changes

anandkaranubc added the Needs Changes Pull request which needs changes before being merged. label Feb 10, 2025

hrshya requested review from anandkaranubc and stdlib-bot February 11, 2025 06:45

hrshya marked this pull request as draft February 11, 2025 15:13

hrshya marked this pull request as ready for review February 11, 2025 15:13

stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Feb 11, 2025

anandkaranubc requested changes Feb 11, 2025

View reviewed changes

hrshya and others added 5 commits February 11, 2025 22:15

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/cd…

37789f8

…f/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/cd…

9b817c7

…f/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/cd…

7098ea1

…f/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/qu…

75762e6

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Update benchmark.js

47ae31a

Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

anandkaranubc requested changes Feb 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/studentized-range/quantile/benchmark/benchmark.js Outdated

anandkaranubc requested changes Feb 11, 2025

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/base/dists/studentized-range/quantile/benchmark/benchmark.js

stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 11, 2025

hrshya and others added 2 commits February 12, 2025 12:46

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/qu…

b104049

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/qu…

e7a3cdd

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

hrshya requested a review from anandkaranubc February 13, 2025 09:37

hrshya changed the title ~~Updated benchmarks~~ bench: refactor number generation Feb 13, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

fix: resolve lint errors

cbde69d

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

anandkaranubc requested changes Feb 17, 2025

View reviewed changes

anandkaranubc removed the Needs Review A pull request which needs code review. label Feb 17, 2025

hrshya and others added 2 commits February 17, 2025 23:38

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/cd…

6bf2b4f

…f/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

Update lib/node_modules/@stdlib/stats/base/dists/studentized-range/qu…

6678b14

…antile/benchmark/benchmark.js Co-authored-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>

hrshya requested a review from anandkaranubc February 17, 2025 18:14

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 17, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

fix: resolve lint errors

204f10c

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

hrshya changed the title ~~bench: refactor number generation~~ bench: refactor random number generation in stats/base/dists/studentized-range Feb 17, 2025

anandkaranubc approved these changes Feb 17, 2025

View reviewed changes

anandkaranubc added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Feb 17, 2025

Planeshifter merged commit 2f54879 into stdlib-js:develop Feb 17, 2025

hrshya deleted the feature/studentized-range branch April 10, 2025 12:33

Uh oh!

Conversation

hrshya commented Feb 10, 2025 • edited by kgryte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hrshya commented Feb 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hrshya commented Feb 17, 2025

Uh oh!

anandkaranubc commented Feb 17, 2025

Uh oh!

anandkaranubc commented Feb 17, 2025

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Feb 17, 2025

Uh oh!

anandkaranubc commented Feb 17, 2025

Uh oh!

hrshya commented Feb 17, 2025

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Feb 17, 2025

PR Commit Message

Uh oh!

Planeshifter commented Feb 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hrshya commented Feb 10, 2025 •

edited by kgryte

Loading

stdlib-bot commented Feb 10, 2025 •

edited

Loading

anandkaranubc left a comment •

edited

Loading