bench: refactor random number generation in stats/base/dists/negative-binomial

[gkbishnoi07]

Description

What is the purpose of this pull request?

This pull request:

• Refactors random number generation in JS benchmarks for stats/base/dists/negative-binomial.
• Replaces randu() with uniform() for cleaner and more consistent code.
• Moves the random number generation outside the benchmarking loops to improve efficiency.

Related Issues

Does this pull request have any related issues?

This pull request:

• Resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/negative-binomial #4980

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/negative-binomial/cdf	$\color{green}272/272$ $\color{green}+100.00\%$	$\color{green}29/29$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}272/272$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/ctor	$\color{green}420/420$ $\color{green}+100.00\%$	$\color{green}31/31$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}420/420$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/kurtosis	$\color{green}122/122$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}122/122$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/logpmf	$\color{red}523/566$ $\color{green}+92.40\%$	$\color{red}45/51$ $\color{green}+88.24\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{red}523/566$ $\color{green}+92.40\%$
stats/base/dists/negative-binomial/mean	$\color{green}126/126$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}126/126$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/mgf	$\color{green}235/235$ $\color{green}+100.00\%$	$\color{green}22/22$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}235/235$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/mode	$\color{green}123/123$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}123/123$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/pmf	$\color{red}532/562$ $\color{green}+94.66\%$	$\color{red}49/57$ $\color{green}+85.96\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{red}532/562$ $\color{green}+94.66\%$
stats/base/dists/negative-binomial/quantile	$\color{green}402/402$ $\color{green}+100.00\%$	$\color{green}52/52$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}402/402$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/skewness	$\color{green}123/123$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}123/123$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/stdev	$\color{green}123/123$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}123/123$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/variance	$\color{green}122/122$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}122/122$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[gkbishnoi07]

@anandkaranubc ready for review

[anandkaranubc]

@anandkaranubc ready for review

@gkbishnoi07, I left some comments for you to review. Please ensure that the suggested changes are applied consistently throughout the PR, including areas where they were not explicitly mentioned but are necessary.

[gkbishnoi07]

@anandkaranubc please review

[anandkaranubc]

Some minor changes. Rest looks good. Great work!

[gkbishnoi07]

Some minor changes. Rest looks good. Great work!

Got it! I'll make the necessary changes. Thanks for the feedback!

[gkbishnoi07]

@anandkaranubc All changes have been applied and are ready for review.

[gkbishnoi07]

@anandkaranubc please review

[gkbishnoi07]

@anandkaranubc any updates

[gkbishnoi07]

@kgryte @hrshya can you please review this PRs

[anandkaranubc]

@anandkaranubc please review

On it!

[anandkaranubc]

After this change, the PR should be ready to merge.

[gkbishnoi07]

@anandkaranubc ready for review

[anandkaranubc]

@anandkaranubc ready for review

Looks good! Thanks for working on this issue. You can wait for a maintainer to merge this PR. In the meantime, please update your title to:

bench: refactor random number generation in stats/base/dists/negative-binomial

Just add the `` around stats/base/dists/negative-binomial

[anandkaranubc]

/stdlib merge

[stdlib-bot]

PR Commit Message

bench: refactor random number generation in stats/base/dists/negative-binomial

PR-URL: https://github.com/stdlib-js/stdlib/pull/5193
Closes: https://github.com/stdlib-js/stdlib/issues/4980

Co-authored-by: Gopi Kishan <gkishan1kyt@gmail.com>

Please review the above commit message and make any necessary adjustments.

[gkbishnoi07]

@anandkaranubc ready for review

Looks good! Thanks for working on this issue. You can wait for a maintainer to merge this PR. In the meantime, please update your title to:

bench: refactor random number generation in stats/base/dists/negative-binomial

Just add the `` around stats/base/dists/negative-binomial

The title is same bench: refactor random number generation in stats/base/dists/negative-binomial??

[Planeshifter]

Thanks @gkbishnoi07 for your PR and @anandkaranubc for review!

[Planeshifter]

@gkbishnoi07

@anandkaranubc ready for review

Looks good! Thanks for working on this issue. You can wait for a maintainer to merge this PR. In the meantime, please update your title to:
bench: refactor random number generation in stats/base/dists/negative-binomial
Just add the `` around stats/base/dists/negative-binomial

The title is same bench: refactor random number generation in stats/base/dists/negative-binomial??

Karan was referring to including backticks around the package path. That's just a convention we have; otherwise PR title was fine.