bench: refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1#5260
Merged
Merged
Conversation
…ase/dists/pareto-type1
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
Author
|
@anandkaranubc ready for review |
Contributor
Author
|
@Planeshifter @kgryte please review this PRs |
anandkaranubc
requested changes
Feb 17, 2025
Contributor
anandkaranubc
left a comment
There was a problem hiding this comment.
Some more changes are required. The rest looks good!
Contributor
Author
|
@anandkaranubc please review |
stats/base/dists/pareto-type1
anandkaranubc
approved these changes
Feb 17, 2025
Contributor
anandkaranubc
left a comment
There was a problem hiding this comment.
The PR looks ready to be merged. Thanks for your work on this! Now, you can wait for a maintainer to merge it.
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Planeshifter
approved these changes
Feb 18, 2025
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks @gkbishnoi07 for your contribution and @anandkaranubc for review! Landing...
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4982
Description
What is the purpose of this pull request?
This pull request:
stats/base/dists/pareto-type1.randu()withuniform()for cleaner and more consistent code.Related Issues
Does this pull request have any related issues?
This pull request:
stats/base/dists/pareto-type1#4982Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.