bench: update random value generation#7748
Conversation
…ts/triangular stdlib-js#4989 Resolves stdlib-js#4989
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hi @anandkaranubc, I’ve made sure all benchmarks pass locally and I’ve addressed all the lint errors that showed up so far (spacing, import order, header formatting, etc.). |
|
@AryanJ18 Thank you for your PR. However, your proposed changes contain significant deviations from our style conventions. I suppose going back through and comparing to other packages to ensure that everything looks and feels like other packages (e.g., in terms of spacing, etc.). |
|
@AryanJ18 The PR looks in good shape overall. Thank you for making the changes as Athan suggested. Just a few changes remain, as mentioned above. |
|
Thank you! I’ll make the remaining changes as suggested and push the update shortly. |
-moved random number generation out of loops -fixed some more identation for more consistency in the code
|
Hi @anandkaranubc , just checking in! I wanted to kindly follow up on this PR. Please let me know if there’s anything else I need to change or if there's any feedback I can work on. Looking forward to your thoughts! |
Resolves #4989
Description
This pull request:
Related Issues
Questions
No.
Other
In the issue it is mentioned to use uniform and discreteUniform to replace randu but I did not find any case in which discreteUniform could be used as per my knowledge
Checklist
@stdlib-js/reviewers