Change build-test runner to ubuntu-24.04-arm#326
Open
DanySK wants to merge 1 commit into
Open
Conversation
| jobs: | ||
| build-test: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04-arm |
There was a problem hiding this comment.
Switching this job to an ARM runner changes the CPU architecture for everything below (notably the Build Go client (Docker) step). Since apps/client-go/Dockerfile.static does not set GOARCH, the produced byteroute-client will now be ARM64 instead of AMD64, so CI will no longer validate the AMD64 Docker build/binary. If you still need AMD64 validation/artifacts, consider either running a matrix over both architectures or pinning the Docker build platform (e.g., docker build --platform=linux/amd64 ...) and/or setting GOARCH explicitly in the Dockerfile.
Suggested change
| runs-on: ubuntu-24.04-arm | |
| runs-on: ubuntu-24.04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.