Conversation
…ut() - _tool_scan_mcp called detect() which misses 3 MCP-specific regex patterns (XML role tags, LLM instruction tags, conversation markers). Now correctly uses Detector().scan_mcp_output(). - Replace silent 'except Exception: pass' in strategy loop with logging.warning(). A security tool should never silently degrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: MCP tool uses wrong detection method
_tool_scan_mcp()calls the genericdetect()function instead ofDetector().scan_mcp_output(). This means 3 MCP-specific regex patterns are never run:<system>,</system>)[INST],<<SYS>>)Human:,Assistant:)The existing test masks this because its injection input triggers the heuristic strategy.
Bug 2: Silent strategy failure
except Exception: passin the detection loop silently swallows all errors. A security tool should not silently degrade — replaced withlogging.warning().Tests
All 190 tests pass.