rev180: Add but not enable new Svn- and FirmwareLimited hierarchies #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanberger
force-pushed
the
stefanberger/rev180.new_hierarchies
branch
2 times, most recently
from
7c7e2cb to
ba936eb
Compare
Move code that determines an OBJECT's hierarchy by its attribute flags into BackwardsCompatibilityObject.c since it will soon only serve the purpose of backwards compatibility. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Add new field hierarchy to OBJECT and assign values to it and access it. Beyond the sync with upstream we need to also set the hierachy when - an older OBJECT is converted to the current OBJECT - an OBJECT is unmarshalled Remove ObjectGetHierarchy since it is not needed anymore. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Introduce new hierarchies SvnLimited and FirmwareLimited but do not enable them. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
stefanberger/rev180.new_hierarchies
branch
from
ba936eb to
f58a5af
Compare
Bump up the StateFormatLevel to 6 and use it to introduce a new OBJECT marshalling format version '4' that slighly changes how an OBJECT is marshalled: - only marshal the private exponent for an RSA key - always marshal the new hierarchy field The marshalling code can still write previous version '3' when an older StateFormatLevel is used to support backwards compatibility. Adjust the test cases marshalling an RSA key OBJECT to check against expected sizes across a series of StateFormatLevels. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
stefanberger/rev180.new_hierarchies
branch
from
f58a5af to
4db4fa2
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds but does not enable the new SvnLimited and FirmwareLimited hierarchies.
The OBJECT now gets a new field 'hierarchy' that is written to and read from. In addition to the sync with the upstream code we need to make sure that OBJECTs always have their hierarchy field set now, which means we have to set it after unmarshalling and converting from older OBJECT types of written by previous versions. The hierachy can be easily derived from an OBJECT's attribute flags.
Bump up the StateFormatLevel to 6 and use it to drive changes to the marshalling of an OBJECT that in its new version 4 now always marshals the hierarchy field but also only marshals the private exponent in case the OBJECT represents an RSA key.