Skip to content

Conversation

@PeterlitsZo
Copy link
Contributor

Set get_part as a classmethod, and add method get_parts

For: #36, #45

@coveralls
Copy link

coveralls commented Oct 28, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling a5e9f91 on PeterlitsZo:patch-1 into 7d146bd on stefankoegl:master.

@PeterlitsZo
Copy link
Contributor Author

Well, I will fix it.

Set get_part as a classmethod, and add method `get_parts`

For: stefankoegl#36, stefankoegl#45
@PeterlitsZo
Copy link
Contributor Author

How can I deal with coverage? I think I need some help~

@PeterlitsZo
Copy link
Contributor Author

Do I need to update tests.py?

@PeterlitsZo
Copy link
Contributor Author

Looks great! but method get_part's usage changed. If you want to pull this, I think it is better to change version.

@stefankoegl
Copy link
Owner

Thanks for the contribution!

but method get_part's usage changed.

Do you see any case that was valid before but is failing now? It should still be ok to call the classmethod from an instance, right?

@PeterlitsZo
Copy link
Contributor Author

OMG, you are so smart. Right at total!

@stefankoegl stefankoegl merged commit 896102d into stefankoegl:master Nov 4, 2021
@stefankoegl
Copy link
Owner

Thanks for your contribution :)

This was referenced Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants