Add has and delete methods to WeakMap#12
Conversation
packages/ember-metal/lib/weak_map.js
Outdated
There was a problem hiding this comment.
What if the value being stored is false or 0
I think the trick will be to do this.get(obj) !== 'undefined' an dif someone tries to set undefined we insert a sentinel value.
Example of such a sentinel: https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/cache.js#L13
https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/cache.js#L13
this prevents a potentially costly in check...
|
Also added check for keys that are not objects when setting |
packages/ember-metal/lib/weak_map.js
Outdated
There was a problem hiding this comment.
value === undefined is what we want here. (perfs)
packages/ember-metal/lib/weak_map.js
Outdated
There was a problem hiding this comment.
lets do function UNDEFINED() {} that way it is named nicely in most modern debuggers.
Add has and delete methods to WeakMap
|
thanks :) |
No description provided.