[ANCHOR-445] Remove unique_address callback#1446
Merged
philipliu merged 12 commits intoAug 26, 2024
Merged
Conversation
philipliu
force-pushed
the
feature/anchor-445-remove-unique-address
branch
from
b7535d6 to
25ee2b1
Compare
philipliu
force-pushed
the
feature/anchor-445-remove-unique-address
branch
6 times, most recently
from
a45503c to
e4b38f5
Compare
philipliu
force-pushed
the
feature/anchor-445-remove-unique-address
branch
from
e4b38f5 to
85aed2f
Compare
JiahuiWho
reviewed
Aug 20, 2024
lijamie98
suggested changes
Aug 20, 2024
| @@ -743,7 +737,7 @@ class Sep31ServiceTest { | |||
| val wantTx = | |||
Contributor
There was a problem hiding this comment.
memo in L735 is assigned twice.
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
memo in L735 is assigned twice.
Nice catch, this variable is no longer used anymore. I deleted it.
Contributor
Author
There was a problem hiding this comment.
Can we use a different package?
The link doesn't seem to work. Can you clarify what you mean?
Contributor
There was a problem hiding this comment.
ah... I cannot recall. It is minor. May be will catch next time.
lijamie98
reviewed
Aug 20, 2024
philipliu
force-pushed
the
feature/anchor-445-remove-unique-address
branch
from
d9df1d7 to
da0569d
Compare
lijamie98
approved these changes
Aug 26, 2024
| @@ -743,7 +737,7 @@ class Sep31ServiceTest { | |||
| val wantTx = | |||
Contributor
There was a problem hiding this comment.
ah... I cannot recall. It is minor. May be will catch next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the
unique_addresscall from the SEP-31POST /transactionendpoint.stellar_account_id,stellar_memo, andstellar_memo_typeare not required fields in the SEP-31 responses, so it's not necessary to generate the deposit address at transaction creation time. This PR updates theRequestOnchainFundsHandlerRPC to allow businesses to populate the deposit address, similar to the SEP-6 and SEP-24 flows.Context
We want to remove the
unique_addresscallback in 3.0.Testing
./gradlew testDocumentation
SEP-31 integration guide and RPC docs will be updated.
Known limitations
N/A