Update wallet sdk to the latest recommended version. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElliotFriend
reviewed
Oct 7, 2024
Contributor
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
Hi, there @saimeunt! Thanks so much for taking on this task!!
Looks like you've got this worked out exactly right! I've tested locally, and everything seems to work perfect. Thanks for taking the time!
There have been some updates to packages (#23), which has resulted in some conflicts in your PR. If you get those conflicts resolved, I can get this merged right away. Thanks!!
There have been some updates to packages that have resulted in some
saimeunt
force-pushed
the
feat/update-wallet-sdk
branch
from
5af8620 to
13558d3
Compare
Contributor
Author
|
@ElliotFriend Hey thank you for your review, I just did what you mentioned and I think it's mergeable now! 👌 |
ElliotFriend
approved these changes
Oct 7, 2024
Contributor
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
Yep! Looks great! Thanks so much @saimeunt!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates away from the deprecated
@stellar/wallet-sdkto the recommended@stellar/typescript-wallet-sdk-km.Fixes #18