-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add unit test #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there @jimenezz22!
This looks pretty great! As I've mentioned I'm not too familiar with setting up unit tests, but it looks like the tests you've written are looking at the right things for the horizon queries.
Looks like you're still planning to work on the other files, but let me know if there's anything else you need. Thanks!
Edit: We've also merged in #23, which updates a lot of package versions, so you'll need to bring in those changes to your branch so there aren't any conflicts.
6072272 to
94899bd
Compare
ElliotFriend
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, there! Thanks for the work on this! Looks like there are a couple regressions from the previously updated packages to take care of, and some changes to incorporate the newer usage patterns of @stellar/stellar-sdk.
Let me know if you have any questions about the comments I left. Thanks!
|
@ElliotFriend I will review the comments and make the requested changes 🫡 |
|
@ElliotFriend All changes for versions applied, some tests doesn't works after the version change, I will focus on solving this 🫡 |
|
gm @ElliotFriend |
ElliotFriend
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @jimenezz22! Thanks again for the work on these tests!
One small JSDoc change, I've requested. Other than that, everything is looking good! Excited to get this merged!
ElliotFriend
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for all the hard work!

Closes #13
@ElliotFriend
Unit tests added for horizonQueries.js:
fetchAccount.test.js
fetchAccountBalances.test.js
fetchRecentPayments.test.js
fundWithFriendbot.test.js
startTransaction.test.js
submit.test.js
findStrictSendPaths.test.js
findStrictReceivePaths.test.js
Al tests passed successfully: