feat: check testnet account for funding #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ElliotFriend please review. |
ElliotFriend
requested changes
Oct 7, 2024
Contributor
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
thanks for the PR! i think you're pretty close. i'm requesting a couple nitpicky changes. after they're resolved, I think this will be good to go!
src/lib/stellar/horizonQueries.js
Outdated
| if (err.response?.status === 404) { | ||
| throw error(404, 'account not funded on network') | ||
| try { | ||
| fundWithFriendbot(publicKey) |
Contributor
There was a problem hiding this comment.
i think you'll want to await fundWithFriendbot(...) here
src/lib/stellar/horizonQueries.js
Outdated
|
|
||
| let account = await server.accounts().accountId(publicKey).call() | ||
| return account | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (error) { | |
| } catch (err) { |
This will be more consistent with the rest of the codebase
Contributor
Author
|
@ElliotFriend , please review again |
ElliotFriend
reviewed
Oct 7, 2024
Contributor
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
one more tiny nitpick and this is ready to go! Thanks!!
src/lib/stellar/horizonQueries.js
Outdated
| return account | ||
| } catch (err) { | ||
| throw error(500, { | ||
| message: `Unable to fund account ${publicKey}: ${error.message}`, |
Contributor
There was a problem hiding this comment.
Suggested change
| message: `Unable to fund account ${publicKey}: ${error.message}`, | |
| message: `Unable to fund account ${publicKey}: ${err.message}`, |
this'll need to change to err, as well
Contributor
Author
|
@ElliotFriend please review again🥲 |
ElliotFriend
approved these changes
Oct 7, 2024
Contributor
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
excellent! Thanks so much for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7