Feat: add stellar ledger as signer #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
changed the title
Contributor
Author
|
@leighmcculloch Moved here |
willemneal
force-pushed
the
feat/add_stellar_ledger
branch
from
2b7c74a to
0aaf7c5
Compare
willemneal
requested review from
elizabethengelman,
fnando and
leighmcculloch
Contributor
Author
|
🎉 Great work! I am so happy to see this almost there and your original work out in the wild! |
elizabethengelman
force-pushed
the
feat/add_stellar_ledger
branch
6 times, most recently
from
4392f87 to
712d408
Compare
elizabethengelman
force-pushed
the
feat/add_stellar_ledger
branch
from
712d408 to
aa00a7f
Compare
elizabethengelman
approved these changes
Feb 12, 2025
Collaborator
elizabethengelman
left a comment
elizabethengelman
left a comment
There was a problem hiding this comment.
This PR is looking good! I tested the following commands out with my ledger:
cargo run keys public-key ledgercargo run keys fund ledgertx signtx sign | tx send
There are a few things that may be worth fixing up in a follow up PR, which I created a new ticket to capture. There is also a failing binary build that is a bit perplexing that I’ve been looking into. It looks like it was failing previous as well, so I’m not sure if it is related this this PR. I'm thinking that we can probably merge this in, and then I can continue to troubleshoot that failing binary build and get a fix pushed up in a new PR.
* Update hickory * Relax deny rules * update deny
elizabethengelman
force-pushed
the
feat/add_stellar_ledger
branch
from
d59e761 to
6d2e7a9
Compare
elizabethengelman
force-pushed
the
feat/add_stellar_ledger
branch
from
6b88253 to
a6a4493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
replaces #1415
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]