Skip to content

[AP] Cut AP release 2.10.0#1018

Merged
lijamie98 merged 6 commits into
stellar:mainfrom
lijamie98:release-2.10
Oct 8, 2024
Merged

[AP] Cut AP release 2.10.0#1018
lijamie98 merged 6 commits into
stellar:mainfrom
lijamie98:release-2.10

Conversation

@lijamie98
Copy link
Copy Markdown
Contributor

No description provided.

@stellar-jenkins
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I don't see the new version in the deployment.


```bash
./gradlew service-runner:bootRun --args=--custody-server
docker run stellar/anchor-platform:2.9.0 --custody-server
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 2.10.0? There are a few other places in this PR that reference 2.9.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@philipliu
Copy link
Copy Markdown
Contributor

Also, what is the difference between 2.9.0 and 2.10.0? Should we add docs for the new Kafka security settings?

@stellar-jenkins
Copy link
Copy Markdown

@lijamie98
Copy link
Copy Markdown
Contributor Author

Also, what is the difference between 2.9.0 and 2.10.0? Should we add docs for the new Kafka security settings?

The changes are Kafka security and bug fixes. They are only defined in YAML file.

@philipliu
Copy link
Copy Markdown
Contributor

The changes are Kafka security and bug fixes. They are only defined in YAML file.

Do we link the version-specific YAML anywhere in the docs? I think maybe we should otherwise, they would need to find the corresponding version in the AP repo.

@lijamie98
Copy link
Copy Markdown
Contributor Author

Also, what is the difference between 2.9.0 and 2.10.0? Should we add docs for the new Kafka security settings?

There is no difference. The new Kafka security settings are documented in the YAML file.

@philipliu
Copy link
Copy Markdown
Contributor

There is no difference. The new Kafka security settings are documented in the YAML file.

Do we expect the developers to know where the YAML file lives in our codebase? They would need to know how to find the version-specific configuration.

@lijamie98
Copy link
Copy Markdown
Contributor Author

Let's discuss in the stand-up.

@JiahuiWho
Copy link
Copy Markdown
Contributor

Is this gonna create version 2.10.0 in the dropdown menu and make it latest?

@lijamie98
Copy link
Copy Markdown
Contributor Author

lijamie98 commented Oct 7, 2024

Is this gonna create version 2.10.0 in the dropdown menu and make it latest?

Verified with local deployment so it is suppose to. Since this is manual process, I will track it down if it does not.

@stellar-jenkins
Copy link
Copy Markdown

@stellar-jenkins
Copy link
Copy Markdown

1 similar comment
@stellar-jenkins
Copy link
Copy Markdown

@stellar-jenkins
Copy link
Copy Markdown

@lijamie98 lijamie98 merged commit 4b111a9 into stellar:main Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants