🪞 EF2 refresh classic guides #1806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page 1 of 6
Page 1 of 6
Page 1 of 6
Page 1 of 6
Page 1 of 6
Page 1 of 6
- Starlight active, details confirmed with SDF at https://discord.com/channels/897514728459468821/907476473739354153/1259478260220301362 - Searching for src on global consensus data packet propogation for relevance in random submisison delay - Need to get hard reference for Protocol 20 one-txn-per-ledger limit
- Use 100px corner rounding
- First time working with this in mdx, pretty nice
Status diction in determinant per stellar/stellar-protocol#1504
I understand there's more to do in `docs\data\READ_FIRST.md`, but I'm just not going to deal with that until stellar#1044
This way only runs the Husky pre-commit if you have yarn installed, which should help with stellar#1044 compatability, given those with write access can quickly (via bot?) run the formatting. i had a lot of problems with this three weeks ago when editing on an offline laptop that didn't have all the dependencies involved. Even though I was going to take care of the nuances on this main desktop here, I couldn't synch up my work to the branch, and thus it was hard to manually override the git commit checks.
Husky changes here should respect stellar#96 given the autochecks run formatter and fail if not prettier at `check MDX` step
Also removes a lot of redundant language from the intent of d5ff964
also bypass the check if yarn run fails for reasons unrelated to file issues like Node version mismatch or corrupt environment
This gets into how deeply we want to epxlain paths in stellar#1545
This cleans up the wording around stellar#1061 without reviewing the pages we notify users about `consistency`. I think a better long-term solution is a "Consistency" flag added to the affected endpoint pages. This could be a simple button akin to the "Supports Streaming" info box. However, even that seems a verbose solution which would also do well to exist as a simple button (akin to ledgerStorage) > two sentences.
…end/stellar-docs into ElliotFriend-refresh-classic-guides
Contributor
Author
|
mirrored due to wrong PR base branch |
Contributor
Author
|
wrong org, meant personal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as JFWooten4#9 but with edit perms