Skip to content

Conversation

@Pfed-prog
Copy link
Contributor

No description provided.

@briwylde08 briwylde08 self-requested a review September 29, 2025 16:51
@briwylde08
Copy link
Contributor

@Pfed-prog This is great! I really like the idea of displaying the clawback flow in images. I wonder if the bar graphs are the best way to do this? Did you explore using a mermaid chart instead? The graphs are alright, but they're quite large, and it's not particularly user-friendly to look at (at least to me).

@JFWooten4
Copy link
Contributor

Mermaid charts are definitely the standard, and there are some examples for inspiration in the ledgers and restoration pages. They have the added benefit of rendering locally with text as searchable fields, although I haven't worked with building them yet. I agree that the bar charts can be a little eye-wandering despite their great raw facts, especially when the X axis changes order in its small font.

Copy link
Contributor

@briwylde08 briwylde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the first table in a collapsible menu since it's so big, but very helpful imagery! Thank you.

@briwylde08 briwylde08 merged commit 5bbc18a into stellar:main Oct 6, 2025
5 checks passed
@JFWooten4
Copy link
Contributor

Bri, thanks for adding a flow chart collapse menu here. Given the size, I agree that it was the right choice to keep the page size reasonable.

Little adjustments at the end of a PR seem really helpful from a contribution point of view, and we've used them to speed up other simple polishes.1 But I'm definitely left wondering what Pavel was going for in example2.png, as it had a different flow which was definitely a little outside my initial comprehension abilities.

Footnotes

  1. My caveat here is that anything even reasonably large goes in a new commit or PR. As long as the original work gets the job completed as laid out, I think it boosts morale to merge as is with only positive feedback. Then it's more like improving on existing work in later amendments.

@Pfed-prog
Copy link
Contributor Author

Bri, thanks for adding a flow chart collapse menu here. Given the size, I agree that it was the right choice to keep the page size reasonable.

Little adjustments at the end of a PR seem really helpful from a contribution point of view, and we've used them to speed up other simple polishes.1 But I'm definitely left wondering what Pavel was going for in example2.png, as it had a different flow which was definitely a little outside my initial comprehension abilities.

I have used all my free credits for the mermaid. And that was the only graph that the website created that looked decent.

Footnotes

  1. My caveat here is that anything even reasonably large goes in a new commit or PR. As long as the original work gets the job completed as laid out, I think it boosts morale to merge as is with only positive feedback. Then it's more like improving on existing work in later amendments.

@JFWooten4
Copy link
Contributor

Was it like an AI thing that only output the image? Thanks, super appreciate it. We can tag-team this—I just know it! 💜

Heck, look at Bri swooping in to save us with a great link right into the CAP35 spec.

@Pfed-prog
Copy link
Contributor Author

@JFWooten4 Both Images were AI.

JFWooten4 added a commit to JFWooten4/stellar-docs that referenced this pull request Dec 18, 2025
implements stellar#1828 translated into mermaid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants