-
Notifications
You must be signed in to change notification settings - Fork 233
added graphs #870 #1828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added graphs #870 #1828
Conversation
|
@Pfed-prog This is great! I really like the idea of displaying the clawback flow in images. I wonder if the bar graphs are the best way to do this? Did you explore using a mermaid chart instead? The graphs are alright, but they're quite large, and it's not particularly user-friendly to look at (at least to me). |
|
Mermaid charts are definitely the standard, and there are some examples for inspiration in the ledgers and restoration pages. They have the added benefit of rendering locally with text as searchable fields, although I haven't worked with building them yet. I agree that the bar charts can be a little eye-wandering despite their great raw facts, especially when the X axis changes order in its small font. |
briwylde08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the first table in a collapsible menu since it's so big, but very helpful imagery! Thank you.
|
Bri, thanks for adding a flow chart collapse menu here. Given the size, I agree that it was the right choice to keep the page size reasonable. Little adjustments at the end of a PR seem really helpful from a contribution point of view, and we've used them to speed up other simple polishes.1 But I'm definitely left wondering what Pavel was going for in Footnotes
|
I have used all my free credits for the mermaid. And that was the only graph that the website created that looked decent. Footnotes
|
|
Was it like an AI thing that only output the image? Thanks, super appreciate it. We can tag-team this—I just know it! 💜 Heck, look at Bri swooping in to save us with a great link right into the CAP35 spec. |
|
@JFWooten4 Both Images were AI. |
implements stellar#1828 translated into mermaid
No description provided.