add phase 2 references #368

ElliotFriend · 2024-03-18T17:01:12Z

No description provided.

ElliotFriend · 2024-03-18T17:03:28Z

@Julian-dev28 I cherry-picked your commit from the other branch, so you can pick up here

stellar-jenkins · 2024-03-18T17:10:08Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

Julian-dev28 · 2024-03-18T21:49:36Z

docs/reference/resource-limits-fees.mdx

-| Events+return value size bytes | 200 B | 8 KB |
+| Network Setting | Phase 0 | Phase 1 (current) | Phase 2 |
+| --- | --- | --- | --- |
+| Soroban Txn per ledger | 1 | 100 | 125 |


@leighmcculloch, @dmkozh, or @MonsieurNicolas

Would you mind providing insight here? I've done my best to translate what I understand from the following proposed config update: link but may have missed some things.

Julian-dev28 · 2024-03-18T21:50:27Z

docs/reference/resource-limits-fees.mdx

+
+Phase 2 marks the deployment of a user-ready Mainnet where anyone can deploy and interact with smart contracts. In this phase, the network is ready for more extensive smart contract utilization, so it's the practical beginning of smart contracts on the Stellar network. But even this is not the end of the journey. At the core of smart contracts on the Stellar network is scale and sustainability, and efforts to continue to expand capacity and introduce further capabilities to enhance the network's functionalities will be ongoing. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and share your feedback in [Discord](https://discord.com/invite/zVYdY3ktTn).
+
+| Network setting | Phase 2 Cost (stroops) |


@leighmcculloch, @dmkozh, or @MonsieurNicolas

Review requested here as well

There have been changes to the write fees (target ledger size and empty/target ledger size fees.

contractLedgerCost.bucketListTargetSizeBytes = 12500000000 //before: 13000000000 contractLedgerCost.writeFee1KbBucketListLow = -193153 //before: -1234673 contractLedgerCost.writeFee1KbBucketListHigh = 57695 //before: 115390

stellar-jenkins · 2024-03-18T21:54:35Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

dmkozh

We have an overhaul planned for the fee/resource documentation. I've left some comments that are hopefully in line with this overhaul (basically get rid of irrelevant information and focus only on the current configuration).

dmkozh · 2024-03-18T21:58:08Z

docs/reference/resource-limits-fees.mdx

-| Temporary entry minimal/initial lifetime | 16 ledgers | 1 day |
-| Max ledger entry expiration bump | 61 days | 6 months |
-| Events+return value size bytes | 200 B | 8 KB |
+| Network Setting | Phase 0 | Phase 1 (current) | Phase 2 |


Let's get rid of the phases here completely, they are not useful for anything really.

dmkozh · 2024-03-18T21:58:46Z

docs/reference/resource-limits-fees.mdx

+| --- | --- | --- | --- |
+| Soroban Txn per ledger | 1 | 100 | 125 |
+| Max CPU Instructions per Txn | 2.5 million (2M instructions for max Wasm) | 100 million (VM instantiation consumes up to 23M for a 64KB Wasm, and 46M for multiple Wasms of 130KB) | 500 million |
+| Memory limit per Txn | 2 MB | 40 MB | 42 MB |


There has been no change here. The difference is really between MiB and MB. I guess we have 40 MiB now de facto. I think we should pick the same unit kind for all the values in the doc. I think KB/MB is a bit easier to parse (though I recognize that KB is often treated as KiB, so I don't have a very strong preference).

dmkozh · 2024-03-18T22:03:20Z

docs/reference/resource-limits-fees.mdx

+| Transaction size | 10 KB | 70 KB | 70 KB |
+| Persistent entry minimal/initial lifetime | 4,096 ledgers (~5.68 hours) | 120 days | 120 days |
+| Temporary entry minimal/initial lifetime | 16 ledgers | 1 day | 1 day |
+| Max ledger entry expiration bump | 61 days | 6 months | N/A |


These aren't N/A, they're the same as in phase 1

dmkozh · 2024-03-18T22:05:44Z

docs/reference/resource-limits-fees.mdx


 The ledger rent cost ('Write 1KB' entries in the table) is based on the write fee, rent period and some coefficient. For the temporary storage, the coefficient is 10 months (in ledgers), thus 1 month of temporary entry rent is 1/10 of the rent fee. For persistent storage the coefficient is 1 month (in ledgers) and thus 1 month of rent is equivalent to the write fee.

+### Phase 2 (next) {#phase-2}


This becomes 'current' tomorrow. I don't think this information is really necessary here.

dmkozh · 2024-03-18T22:08:23Z

docs/reference/resource-limits-fees.mdx

+
+Phase 2 marks the deployment of a user-ready Mainnet where anyone can deploy and interact with smart contracts. In this phase, the network is ready for more extensive smart contract utilization, so it's the practical beginning of smart contracts on the Stellar network. But even this is not the end of the journey. At the core of smart contracts on the Stellar network is scale and sustainability, and efforts to continue to expand capacity and introduce further capabilities to enhance the network's functionalities will be ongoing. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and share your feedback in [Discord](https://discord.com/invite/zVYdY3ktTn).
+
+| Network setting | Phase 2 Cost (stroops) |


There have been changes to the write fees (target ledger size and empty/target ledger size fees.

contractLedgerCost.bucketListTargetSizeBytes = 12500000000 //before: 13000000000 contractLedgerCost.writeFee1KbBucketListLow = -193153 //before: -1234673 contractLedgerCost.writeFee1KbBucketListHigh = 57695 //before: 115390

dmkozh · 2024-03-18T22:08:46Z

docs/reference/resource-limits-fees.mdx

+
+Phase 2 marks the deployment of a user-ready Mainnet where anyone can deploy and interact with smart contracts. In this phase, the network is ready for more extensive smart contract utilization, so it's the practical beginning of smart contracts on the Stellar network. But even this is not the end of the journey. At the core of smart contracts on the Stellar network is scale and sustainability, and efforts to continue to expand capacity and introduce further capabilities to enhance the network's functionalities will be ongoing. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and share your feedback in [Discord](https://discord.com/invite/zVYdY3ktTn).
+
+| Network setting | Phase 2 Cost (stroops) |


I don't think we need to separate this by phase, let's just update the values in-place.

stellar-jenkins · 2024-03-18T23:18:28Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

dmkozh · 2024-03-18T23:26:19Z

docs/reference/resource-limits-fees.mdx


 Soroban introduces smart contracts, marking the most transformative upgrade to the Stellar network to date. To maintain network performance, the ecosystem has decided to upgrade the network in a phased approach where network capacity is increased gradually over time. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and [Discord](https://discord.com/invite/zVYdY3ktTn) for current status.

-| Network Setting | Phase 0 | Phase 1 (current) |


I didn't meant to remove the whole table, I meant we should just remove mentions of the phases and just have a single two column table (setting-value). Sorry for the confusion.
We don't need 2 separate tables for fees though, just one (with current value) would suffice.

Julian-dev28 · 2024-03-18T23:26:38Z

docs/reference/resource-limits-fees.mdx

-Phase 2 marks the deployment of a user-ready Mainnet where anyone can deploy and interact with smart contracts. In this phase, the network is ready for more extensive smart contract utilization, so it's the practical beginning of smart contracts on the Stellar network. But even this is not the end of the journey. At the core of smart contracts on the Stellar network is scale and sustainability, and efforts to continue to expand capacity and introduce further capabilities to enhance the network's functionalities will be ongoing. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and share your feedback in [Discord](https://discord.com/invite/zVYdY3ktTn).
-
-| Network setting | Phase 2 Cost (stroops) |
+| Network setting | Cost (stroops) |


Hey @dmkozh thanks for the feedback.

Does this commit address the following correctly?:

I don't think we need to separate this by phase, let's just update the values in-place.

stellar-jenkins · 2024-03-18T23:30:59Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

gre3n3yes34 · 2024-03-19T01:31:46Z

Unsubscribe

…

On Mon, Mar 18, 2024, 4:31 PM stellar-jenkins ***@***.***> wrote: *Preview is available here:* http://developers-pr368.previews.kube001.services.stellar-ops.com — Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5LQRFMDGDT6WQ7VBVSGECTYY52MXAVCNFSM6AAAAABE37KW2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGI4TENZQHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

briwylde08 · 2024-03-19T13:53:14Z

docs/reference/resource-limits-fees.mdx

-
 ## Resource Fees

 Note that write fees grow linearly from empty ledger to ledger "target size", and then grow linearly, but with a 1000x factor after exceeding the target. This is to bound the ledger size growth.


This may just be me, but the first sentence doesn't read quite right. We say that the "...write fees grow linearly from empty ledger to ledger "target size", and then grow linearly..." so we say that write fees grow linearly twice. Is that purposeful?

The distinction is in the next half of the sentence: "... but with a 1000x factor after exceeding the target." As it's written, it is quite confusing, but I'm not sure a better way to say it.

Essentially, the write fee can be affected by the current size of the blockchain (that's what ledger "target size" is referring to [i'm pretty sure...]):

while size_of_blockchain >= "target size" ... write fee = fee_that_grows_linearly

while size_of_blockchain > "target size" ... write fee = fee_that_grows_linearly * 1000

@dmkozh Could probably say definitively if I understand it correctly.

Your understanding is correct. Also please feel free to come up with a better term than 'target ledger size'. Maybe we should use something like 'ledger growth threshold' and clarify that the threshold will grow over time and it's introduced only to prevent explosive state growth.

ElliotFriend · 2024-03-19T14:14:05Z

docs/reference/resource-limits-fees.mdx

-| Network Setting | Phase 0 | Phase 1 (current) | Phase 2 |
-| --- | --- | --- | --- |
-| Soroban Txn per ledger | 1 | 100 | 125 |
-| Max CPU Instructions per Txn | 2.5 million (2M instructions for max Wasm) | 100 million (VM instantiation consumes up to 23M for a 64KB Wasm, and 46M for multiple Wasms of 130KB) | 500 million |
-| Memory limit per Txn | 2 MB | 40 MB | 42 MB |
-| Ledger entry size (including Wasm entries) per Txn | 2 KB | 64 KB | 66 KB |
-| Read/Write Ledger entries per Txn | 3 read; 2 write | 40 read; 25 write | 40 read; 25 write |
-| Read/Write bytes per Txn | 3.2 KB read; 3.2 KB write | 130 KB read; 65 KB write | 133 KB read; 66 KB write |
-| Transaction size | 10 KB | 70 KB | 70 KB |
-| Persistent entry minimal/initial lifetime | 4,096 ledgers (~5.68 hours) | 120 days | 120 days |
-| Temporary entry minimal/initial lifetime | 16 ledgers | 1 day | 1 day |
-| Max ledger entry expiration bump | 61 days | 6 months | N/A |
-| Events+return value size bytes | 200 B | 8 KB | N/A |
-


I think we'll actually want to keep this table (at least some? most?). Rather, just remove the Phase 0 and Phase 1 columns, and just have:

| Network Setting | Value | | --- | --- | | Soroban Txn per ledger | 100 | | etc. | etc. |

stellar-jenkins · 2024-03-19T15:05:39Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-03-19T15:32:24Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-03-19T15:35:27Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-03-19T15:59:28Z

Preview is available here:
http://developers-pr368.previews.kube001.services.stellar-ops.com

* add phase 2 references * Update resource-limits-fees.mdx * remove comparative table; update P2 costs * Remove phases * added resource limit table & changed "phase 1" to "phase 2" * formatting, removing phase language * update table values * update network settings values --------- Co-authored-by: Julian Martinez <julian_martinez28@outlook.com> Co-authored-by: Bri <92327786+briwylde08@users.noreply.github.com>

add phase 2 references

8506438

ElliotFriend assigned ElliotFriend and Julian-dev28 and unassigned ElliotFriend Mar 18, 2024

Update resource-limits-fees.mdx

4e5c482

Julian-dev28 reviewed Mar 18, 2024

View reviewed changes

Julian-dev28 requested a review from leighmcculloch March 18, 2024 21:51

dmkozh reviewed Mar 18, 2024

View reviewed changes

remove comparative table; update P2 costs

c5c69fd

Remove phases

3518f01

dmkozh reviewed Mar 18, 2024

View reviewed changes

Julian-dev28 reviewed Mar 18, 2024

View reviewed changes

briwylde08 reviewed Mar 19, 2024

View reviewed changes

ElliotFriend commented Mar 19, 2024

View reviewed changes

added resource limit table & changed "phase 1" to "phase 2"

672c839

briwylde08 and others added 2 commits March 19, 2024 09:24

formatting, removing phase language

41eb234

update table values

d39c2d5

update network settings values

690b405

ElliotFriend requested a review from briwylde08 March 19, 2024 16:00

briwylde08 approved these changes Mar 19, 2024

View reviewed changes

ElliotFriend merged commit 350c391 into main Mar 19, 2024

ElliotFriend deleted the phase-2-fees-limits branch March 19, 2024 16:01


		Phase 2 marks the deployment of a user-ready Mainnet where anyone can deploy and interact with smart contracts. In this phase, the network is ready for more extensive smart contract utilization, so it's the practical beginning of smart contracts on the Stellar network. But even this is not the end of the journey. At the core of smart contracts on the Stellar network is scale and sustainability, and efforts to continue to expand capacity and introduce further capabilities to enhance the network's functionalities will be ongoing. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and share your feedback in [Discord](https://discord.com/invite/zVYdY3ktTn).

		\| Network setting \| Phase 2 Cost (stroops) \|


		The ledger rent cost ('Write 1KB' entries in the table) is based on the write fee, rent period and some coefficient. For the temporary storage, the coefficient is 10 months (in ledgers), thus 1 month of temporary entry rent is 1/10 of the rent fee. For persistent storage the coefficient is 1 month (in ledgers) and thus 1 month of rent is equivalent to the write fee.

		### Phase 2 (next) {#phase-2}


		Soroban introduces smart contracts, marking the most transformative upgrade to the Stellar network to date. To maintain network performance, the ecosystem has decided to upgrade the network in a phased approach where network capacity is increased gradually over time. See [this blog post](https://stellar.org/blog/developers/the-stellar-network-s-phased-rollout-of-smart-contracts-the-road-to-mainnet) for more details and [Discord](https://discord.com/invite/zVYdY3ktTn) for current status.

		\| Network Setting \| Phase 0 \| Phase 1 (current) \|


		## Resource Fees

		Note that write fees grow linearly from empty ledger to ledger "target size", and then grow linearly, but with a 1000x factor after exceeding the target. This is to bound the ledger size growth.

add phase 2 references #368

add phase 2 references #368

Uh oh!

Conversation

ElliotFriend commented Mar 18, 2024

Uh oh!

ElliotFriend commented Mar 18, 2024

Uh oh!

stellar-jenkins commented Mar 18, 2024

Uh oh!

Julian-dev28 Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Mar 18, 2024

Uh oh!

dmkozh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Mar 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Mar 18, 2024

Uh oh!

gre3n3yes34 commented Mar 19, 2024 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Mar 19, 2024

Uh oh!

stellar-jenkins commented Mar 19, 2024

Uh oh!

stellar-jenkins commented Mar 19, 2024

Uh oh!

stellar-jenkins commented Mar 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Julian-dev28 Mar 18, 2024 •

edited

Loading