Refactor error handling page #649

aditya1702 · 2024-06-04T20:41:56Z

Updates the error-handling page: https://developers.stellar.org/docs/learn/encyclopedia/error-handling. Adds information about error handling strategies for async transaction submission endpoint.
Update the error handling strategies for non-async transaction submission: On 504 timeout, instead of recommending users to always retry submissions, redirect them to check for the tx status and then retry if the txn is not included in a ledger. Simultaneous PR to add the tx hash to timeout response: https://github.com/stellar/go/pull/5328
Moves the page from encyclopedia to admin-guide in Horizon docs.

stellar-jenkins · 2024-06-04T20:48:42Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-06-04T21:03:47Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-06-04T21:09:53Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

network/horizon/admin-guide/error-handling.mdx

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>

stellar-jenkins · 2024-06-05T16:26:53Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>

stellar-jenkins · 2024-06-06T14:53:12Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>

stellar-jenkins · 2024-06-06T15:15:41Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

Shaptic

Nice work! I did a quick first pass review

network/horizon/admin-guide/error-handling.mdx

Co-authored-by: Molly Karcher <mdarkar@gmail.com>

Co-authored-by: George <Shaptic@users.noreply.github.com>

stellar-jenkins · 2024-07-03T20:42:22Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

Co-authored-by: George <Shaptic@users.noreply.github.com>

stellar-jenkins · 2024-07-03T20:56:45Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-07-03T21:01:37Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-03T21:01:37Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-03T21:01:37Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-03T21:13:52Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-03T21:14:21Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-03T21:16:13Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-03T21:16:13Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

Co-authored-by: George <Shaptic@users.noreply.github.com>

# Conflicts: # docs/build/guides/basics/create-account.mdx # docs/build/guides/basics/send-and-receive-payments.mdx

stellar-jenkins · 2024-07-08T16:26:05Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-08T16:27:20Z

Something went wrong with PR preview build please check

stellar-jenkins · 2024-07-08T19:22:01Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

stellar-jenkins · 2024-07-08T20:34:36Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

Shaptic

👏 👏 👏 great effort on this!!

stellar-jenkins · 2024-07-08T20:58:52Z

Preview is available here:
http://developers-pr649.previews.kube001.services.stellar-ops.com

aditya1702 added 6 commits May 30, 2024 11:53

Add getTransactions documentation - 3

96f60fa

Merge branch 'refs/heads/main' into error-handling

7c9df3b

Add getTransactions documentation - 5

9ce5a78

Refactor error-handling page - 1

1d3e6c3

Move error-handling to admin-guide

adf9968

Format table

d8184e7

aditya1702 requested review from JakeUrban, Shaptic, janewang and mollykarcher June 4, 2024 20:42

aditya1702 added 2 commits June 4, 2024 16:54

Fix docs path

13cd1ff

Fix docs path - 2

8abee6a

JakeUrban reviewed Jun 5, 2024

View reviewed changes

Update network/horizon/admin-guide/error-handling.mdx

6ceebd9

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>

Update network/horizon/admin-guide/error-handling.mdx

1f4e1b2

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>

Update network/horizon/admin-guide/error-handling.mdx

d9ddda5

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>

Shaptic reviewed Jun 6, 2024

View reviewed changes

mollykarcher reviewed Jun 7, 2024

View reviewed changes

aditya1702 and others added 6 commits June 7, 2024 13:58

Merge branch 'refs/heads/main' into error-handling

9e4aab1

Move error-handling to Errors section

964734e

Update network/horizon/admin-guide/error-handling.mdx

59cf2a5

Co-authored-by: Molly Karcher <mdarkar@gmail.com>

Update network/horizon/admin-guide/error-handling.mdx

bfa97e7

Co-authored-by: George <Shaptic@users.noreply.github.com>

Update network/horizon/admin-guide/error-handling.mdx

e2475d8

Co-authored-by: George <Shaptic@users.noreply.github.com>

Update network/horizon/admin-guide/error-handling.mdx

7000cf3

Co-authored-by: George <Shaptic@users.noreply.github.com>

aditya1702 and others added 2 commits July 3, 2024 16:41

Update docs/data/horizon/api-reference/errors/error-handling.mdx

5e7feb1

Co-authored-by: George <Shaptic@users.noreply.github.com>

Update docs/data/horizon/api-reference/errors/error-handling.mdx

24fa327

Co-authored-by: George <Shaptic@users.noreply.github.com>

aditya1702 and others added 4 commits July 3, 2024 16:43

Update docs/data/horizon/api-reference/errors/error-handling.mdx

07aff89

Co-authored-by: George <Shaptic@users.noreply.github.com>

Update docs/data/horizon/api-reference/errors/error-handling.mdx

43dc887

Co-authored-by: George <Shaptic@users.noreply.github.com>

Update docs/data/horizon/api-reference/errors/error-handling.mdx

572da8a

Co-authored-by: George <Shaptic@users.noreply.github.com>

Update docs/data/horizon/api-reference/errors/error-handling.mdx

3c08c61

Co-authored-by: George <Shaptic@users.noreply.github.com>

aditya1702 and others added 2 commits July 8, 2024 12:14

Update docs/data/horizon/api-reference/errors/error-handling.mdx

d1f3e36

Co-authored-by: George <Shaptic@users.noreply.github.com>

Merge branch 'refs/heads/main' into error-handling

49cfe97

# Conflicts: # docs/build/guides/basics/create-account.mdx # docs/build/guides/basics/send-and-receive-payments.mdx

aditya1702 added 2 commits July 8, 2024 12:27

Final changes - 1

e1ad6a8

Fix broken link

4d4bb1d

Add polling code

f32c1e2

aditya1702 requested a review from Shaptic July 8, 2024 20:25

Shaptic approved these changes Jul 8, 2024

View reviewed changes

Fix caution section

8c5e14e

aditya1702 merged commit c8ad0db into stellar:main Jul 8, 2024

aditya1702 deleted the error-handling branch December 12, 2024 17:23

Refactor error handling page #649

Refactor error handling page #649

Uh oh!

Conversation

aditya1702 commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stellar-jenkins commented Jun 4, 2024

Uh oh!

stellar-jenkins commented Jun 4, 2024

Uh oh!

stellar-jenkins commented Jun 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stellar-jenkins commented Jun 5, 2024

Uh oh!

stellar-jenkins commented Jun 6, 2024

Uh oh!

stellar-jenkins commented Jun 6, 2024

Uh oh!

Shaptic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 3, 2024

Uh oh!

stellar-jenkins commented Jul 8, 2024

Uh oh!

stellar-jenkins commented Jul 8, 2024

Uh oh!

stellar-jenkins commented Jul 8, 2024

Uh oh!

stellar-jenkins commented Jul 8, 2024

Uh oh!

Shaptic left a comment

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins commented Jul 8, 2024

Uh oh!

Reviewers

Assignees

aditya1702 commented Jun 4, 2024 •

edited

Loading