You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Please explain why you think deny all is unnecessary? And if it's interfering with another rule down below, then I think we should move it below that rule instead of eliminating it.
Please explain why you think deny all is unnecessary? And if it's interfering with another rule down below, then I think we should move it below that rule instead of eliminating it.
Hi @mwtzzz, Nginx does not allow adding duplicate locations, so moving it below is not feasible. Instead, any files in the /mnt/xvdf/stellar-core-archive/node_001/ folder are not private and can be made public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
location / { deny all; }conflicts with the later definedlocation / {...}and I think it is unnecessary, we can remove it.try_filesis incorrect, we need to correct it. https://nginx.org/en/docs/http/ngx_http_core_module.html#try_files