Skip to content

fix nginx config.#673

Merged
briwylde08 merged 1 commit into
stellar:mainfrom
lightsail-network:fix-nginx-config
Jun 25, 2024
Merged

fix nginx config.#673
briwylde08 merged 1 commit into
stellar:mainfrom
lightsail-network:fix-nginx-config

Conversation

@overcat
Copy link
Copy Markdown
Contributor

@overcat overcat commented Jun 12, 2024

  1. location / { deny all; } conflicts with the later defined location / {...} and I think it is unnecessary, we can remove it.
  2. The usage of try_files is incorrect, we need to correct it. https://nginx.org/en/docs/http/ngx_http_core_module.html#try_files

@stellar-jenkins
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@mwtzzz mwtzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why you think deny all is unnecessary? And if it's interfering with another rule down below, then I think we should move it below that rule instead of eliminating it.

@overcat
Copy link
Copy Markdown
Contributor Author

overcat commented Jun 15, 2024

Please explain why you think deny all is unnecessary? And if it's interfering with another rule down below, then I think we should move it below that rule instead of eliminating it.

Hi @mwtzzz, Nginx does not allow adding duplicate locations, so moving it below is not feasible. Instead, any files in the /mnt/xvdf/stellar-core-archive/node_001/ folder are not private and can be made public.

@briwylde08 briwylde08 requested review from mwtzzz and removed request for ElliotFriend, Julian-dev28 and Shaptic June 18, 2024 17:27
@briwylde08
Copy link
Copy Markdown
Contributor

Hi @mwtzzz! Are you okay reviewing this PR?

Copy link
Copy Markdown
Contributor

@mwtzzz mwtzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@briwylde08
Copy link
Copy Markdown
Contributor

Hi @overcat! Are you able to fix the conflict? Then we're good to merge!

@overcat overcat force-pushed the fix-nginx-config branch from 3878436 to 960b049 Compare June 25, 2024 09:48
@overcat
Copy link
Copy Markdown
Contributor Author

overcat commented Jun 25, 2024

Hi @overcat! Are you able to fix the conflict? Then we're good to merge!

Hi @briwylde08, resolved.

@stellar-jenkins
Copy link
Copy Markdown

@briwylde08 briwylde08 merged commit ba8c22d into stellar:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants