Prevent OpenRPC-generated pages from using the @theme/ApiItem component#720
Merged
Conversation
ElliotFriend
changed the title
@theme/ApiItem page@theme/ApiItem component
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
Contributor
Author
|
Relevant preview pages: The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #709 (here is the exact comment), the
@theme/ApiItemcomponent from thedocusaurus-theme-openapi-docspackage (as well as our swizzled/src/theme/ApiItem/Layoutcomponent) adds some styling/layout that we don't really want to see in the pages generated using theopen-rpc-docs-reactcomponent. Namely, as pointed out in #709, any<CodeBlock>components are floated to the right-hand side of the screen (wrapping the code block component in a<div>seems to do the trick to workaround it, btw).This PR aims to ensure that the URL of a page rendered with
@theme/ApiItemdoesn't includerpc, and will use the default@theme/DocItemcomponent, instead.