Skip to content

Conversation

@fnando
Copy link
Member

@fnando fnando commented Jul 5, 2024

Here's a screenshot of what it looks like:

CleanShot 2024-07-04 at 19 22 06

Here's the preview link: https://developers-pr755.previews.kube001.services.stellar-ops.com/docs/build/smart-contracts/stellar-cli

@stellar-jenkins
Copy link

@fnando fnando force-pushed the stellar-cli-help-autogen branch 2 times, most recently from b022375 to 5b00c18 Compare July 5, 2024 01:53
@fnando fnando force-pushed the stellar-cli-help-autogen branch from 5b00c18 to c1ffebf Compare July 5, 2024 01:56
@stellar-jenkins
Copy link

2 similar comments
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chadoh
Copy link
Contributor

chadoh commented Jul 8, 2024

The lack of indentation in the sidebar is a bummer; I've created ConnorGray/clap-markdown#31 to address it. I see you also created ConnorGray/clap-markdown#30, @fnando — I vote we add these issues to our own project board so we can ensure they get done quickly, @janewang.

@briwylde08
Copy link
Contributor

briwylde08 commented Jul 8, 2024

Location suggestion- can we pull this out into its own section, so it would go:

Tools Overview
SDKs
Developer Tools
Stellar CLI Manual

And then rename it to the Stellar CLI Manual so it's shorter? LMK what you think!

@stellar-jenkins
Copy link

@fnando
Copy link
Member Author

fnando commented Jul 10, 2024

@briwylde08 great suggestion! The new title is way nicer!

CleanShot 2024-07-10 at 10 38 02@2x

@fnando fnando marked this pull request as ready for review July 10, 2024 13:38
@stellar-jenkins
Copy link

@janewang janewang self-requested a review July 10, 2024 13:59
@fnando fnando merged commit 4a3d6b6 into main Jul 10, 2024
@fnando fnando deleted the stellar-cli-help-autogen branch July 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants