Fix bootstrap script ffmpeg extraction + stabilize Demucs stem filenames#105
Draft
ahetrick12 wants to merge 1 commit intostemrollerapp:mainfrom
Draft
Fix bootstrap script ffmpeg extraction + stabilize Demucs stem filenames#105ahetrick12 wants to merge 1 commit intostemrollerapp:mainfrom
ahetrick12 wants to merge 1 commit intostemrollerapp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues:
Changes
Updated
download-third-party-apps.js:moveDirChildrenUpAndDeleteDirto skip gracefully when the source directory does not exist.Updated
processQueue.js:findDemucsOutputDirso it also accepts files written directly in the base output directory (not only nested subdirectory layout).Testing
Tested only on Windows 11
npm run download-third-party-apps, confirmed no failurestest .wavfilename; fails on latest release, succeeds with these changes